Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR] Clarify UR_DEVICE_TYPE_ALL usage. #17629

Merged
merged 2 commits into from
Mar 27, 2025
Merged

[UR] Clarify UR_DEVICE_TYPE_ALL usage. #17629

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6d4ab3
[UR] Clarify UR_DEVICE_TYPE_ALL usage.
isaacault Mar 25, 2025
fe1c56d
Merge branch 'sycl' into issue-17527
isaacault Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion unified-runtime/include/ur_api.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion unified-runtime/scripts/core/device.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@ etors:
value: "1"
desc: "The default device type as preferred by the runtime"
- name: ALL
desc: "Devices of all types"
desc: |
Devices of all types, for use with $xDeviceGet() and
$xDeviceGetSelected(). This value will never be returned when
querying about a device.
- name: GPU
desc: "Graphics Processing Unit"
- name: CPU
Expand Down
2 changes: 1 addition & 1 deletion unified-runtime/scripts/core/manifests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# See YaML.md for syntax definition
#
# NOTE: device_types must be explictly listed. Refrain from using
# $X_DEVICE_TYPE_ALL. See https://github.com/intel/llvm/issues/17527.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can consider this issue addressed with the change here, can you put a "Fixes" clause in the PR description so it gets closed automatically

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

# $X_DEVICE_TYPE_ALL.
--- #--------------------------------------------------------------------------
type: header
desc: "Intel $OneApi Unified Runtime adapter manifests"
Expand Down
Loading