[UR] Clarify UR_DEVICE_TYPE_ALL usage. #17629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update spec to clarify that this is not a value to be returned.
aarongreig
reviewed
Mar 25, 2025
| @@ -8,7 +8,7 @@ | |||
| # See YaML.md for syntax definition | |||
| # | |||
| # NOTE: device_types must be explictly listed. Refrain from using | |||
| # $X_DEVICE_TYPE_ALL. See https://github.com/intel/llvm/issues/17527. | |||
There was a problem hiding this comment.
I think we can consider this issue addressed with the change here, can you put a "Fixes" clause in the PR description so it gets closed automatically
aarongreig
approved these changes
Mar 25, 2025
|
@intel/llvm-gatekeepers this is ready. Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update spec to clarify that this is not a value to be returned.
Fixes #17527