[SYCL][E2E][Matrix] Restrict XFAIL in some tests to DG2 #17639
Conversation
Signed-off-by: Sarnie, Nick <[email protected]>
There was a problem hiding this comment.
@sarnex , are they indeed failing in pre/post-commit? Or are they actually skipped because there is an XFAIL and multiple backends?
What if you just remove XFAIL. Probably, it will just pass in pre/post-commit.
Could you please try that?
Also, are we using different gpu driver versions in nightly and pre/post-commit?
Signed-off-by: Sarnie, Nick <[email protected]>
|
Driver should be the same, testing that now |
ok, based on testing results - passed on PVC, failed on DG2. Hence, xfail needs to be there for 2 tests, but only for DG2 architecture, which makes sense to me (feature is implemented only for PVC/BMG for now). |
Signed-off-by: Sarnie, Nick <[email protected]>
|
done |
|
@sarnex , you may want to update title/description, before merging. Thanks for taking care of it! |
sarnex
changed the title
|
Done, thx |
|
@YuriPlyakhin They're failing on BMG |
Then, pls, add |
Signed-off-by: Sarnie, Nick <[email protected]>
| @@ -18,7 +18,7 @@ | |||
| // This tests support of col major layout for matrix B which does transpose and | |||
| // then VNNI transform. This is currently only available on AMX | |||
|
|
|||
| // XFAIL: gpu | |||
| // XFAIL: gpu-intel-dg2 || arch-intel_gpu_bmg_g21 | |||
| // XFAIL-TRACKER: GSD-5768 | |||
There was a problem hiding this comment.
The BMG part is fine.
But for dg2, we need add:
"
// SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2
// UNSUPPORTED: gpu-intel-dg2
"
There was a problem hiding this comment.
just pushed a new commit that should address this, thanks!
Signed-off-by: Sarnie, Nick <[email protected]>
|
Merging since nightly is broken, happy to address anything post-commit. |
XPASSing in nightly but failing in pre/postcommit, make them XFAIL only where they actually fail.