Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E][Matrix] Restrict XFAIL in some tests to DG2 #17639

Merged
merged 5 commits into from
Mar 27, 2025
Merged

[SYCL][E2E][Matrix] Restrict XFAIL in some tests to DG2 #17639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66c175f
[SYCL][E2E][Matrix] Move XPASSing tests in nightly to unsupported
sarnex Mar 25, 2025
73d87b9
remove xfail
sarnex Mar 26, 2025
ee0f930
xfail dg2
sarnex Mar 26, 2025
63ea60b
bmg
sarnex Mar 26, 2025
b0f4614
feedback
sarnex Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sycl/test-e2e/Matrix/SG32/get_coordinate_ops.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
// REQUIRES: aspect-ext_intel_matrix
// REQUIRES-INTEL-DRIVER: lin: 30049, win: 101.4943

// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: GSD-10524

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
5 changes: 4 additions & 1 deletion sycl/test-e2e/Matrix/SG32/joint_matrix_int8_colmajorA_colmajorB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@
// This tests support of col major layout for matrix B which does transpose and
// then VNNI transform. This is currently only available on AMX

// XFAIL: gpu
// XFAIL: arch-intel_gpu_bmg_g21
// XFAIL-TRACKER: GSD-5768
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BMG part is fine.
But for dg2, we need add:
"
// SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2
// UNSUPPORTED: gpu-intel-dg2
"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just pushed a new commit that should address this, thanks!


// UNSUPPORTED: gpu-intel-dg2
// UNSUPPORTED-INTENDED: SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2

#include "common.hpp"

using namespace sycl;
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Matrix/joint_matrix_int8_colmajorA_colmajorB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
// This tests support of col major layout for matrix B which does transpose and
// then VNNI transform. This is currently only available on AMX

// XFAIL: gpu
// XFAIL: gpu-intel-dg2 || arch-intel_gpu_bmg_g21
// XFAIL-TRACKER: GSD-5768

#include "common.hpp"
Expand Down
Loading