Skip to content

[SYCL][L0 v2] Use counter-based events #20788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mateuszpn wants to merge 6 commits into
base: sycl
Choose a base branch
from
Open

[SYCL][L0 v2] Use counter-based events #20788

mateuszpn wants to merge 6 commits into from
+123 −40

Conversation

@mateuszpn
Copy link
Contributor

@mateuszpn mateuszpn commented Dec 1, 2025

Use counter-based events in level-zero v2 adapter

@mateuszpn mateuszpn requested a review from a team as a code owner December 1, 2025 13:44
@mateuszpn mateuszpn marked this pull request as draft December 1, 2025 13:44
@mateuszpn mateuszpn changed the title Use counter-based events [SYCL][L0 v2] Use counter-based events Dec 1, 2025
@mateuszpn mateuszpn marked this pull request as ready for review December 1, 2025 14:32
@kswiecicki
Copy link
Contributor

kswiecicki commented Dec 2, 2025

SYCL Pre Commit on Windows fails with event handle leak checking error, it seems that the zexCounterBasedEventCreate2 is not correctly tracked on Windows.

@pbalcer pbalcer mentioned this pull request Dec 2, 2025
Closed
KFilipek
KFilipek approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateuszpn
add fallback to provider_normal
adf4977 
Signed-off-by: Mateusz P. Nowak <[email protected]>
@mateuszpn
fix tests
d55a487 
Signed-off-by: Mateusz P. Nowak <[email protected]>
kswiecicki
kswiecicki requested changes Dec 4, 2025
View reviewed changes
@mateuszpn mateuszpn requested a review from a team as a code owner December 8, 2025 09:43
@mateuszpn mateuszpn requested a review from againull December 8, 2025 09:43
@mateuszpn
Copy link
Contributor Author

mateuszpn commented Dec 8, 2025

SYCL Pre Commit on Windows fails with event handle leak checking error, it seems that the zexCounterBasedEventCreate2 is not correctly tracked on Windows.

#20852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KFilipek KFilipek KFilipek approved these changes

@kswiecicki kswiecicki kswiecicki approved these changes

@againull againull Awaiting requested review from againull againull is a code owner automatically assigned from intel/llvm-reviewers-runtime

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mateuszpn @kswiecicki @KFilipek