Enable _linalg_det, _linalg_slogdet and _linalg_solve_ex related operations on xpu
#1660
+58
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces optimized XPU-specific support for determinant and sign/log-determinant operations by dispatching to dedicated XPU kernels and removing fallbacks. It also updates the test suite and skip lists accordingly to reflect the new support.
- Added YAML entries for _linalg_det and _linalg_slogdet with structured delegates and XPU-specific dispatch.
- Updated test files to include new LU-family and LU-solve tests while removing obsolete fallback tests.
- Removed fallback implementations and adjusted skip lists in test files.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yaml/native/native_functions.yaml | Added structured function entries for _linalg_det and _linalg_slogdet with XPU dispatch support. |
| test/xpu/test_linalg_xpu.py | Introduced new tests for LU-family and LU-solve operations; refactored imports and test registration. |
| test/xpu/skip_list_common.py | Removed skip tests related to linalg_det and linalg_slogdet operations. |
| src/ATen/native/xpu/mkl/BatchLinearAlgebra.h | Defined new MKL-based linear algebra function prototypes for XPU. |
| src/ATen/native/xpu/BatchLinearAlgebra.cpp | Added XPU kernel implementations for SVD, LU solve, and LU factor with CPU fallback support. |
Files not reviewed (1)
- src/ATen/native/xpu/XPUFallback.template: Language not supported
huiyan2021
changed the title
_linalg_det and _linalg_slogdet related operations on xpu_linalg_det, _linalg_slogdet and _linalg_solve_ex related operations on xpu
CuiYifeng
force-pushed
the
huiyan/linalg_det
branch
2 times, most recently
from
a33b0a8 to
a37b03e
Compare
CuiYifeng
requested changes
May 28, 2025
yaml/native/native_functions.yaml
Outdated
Comment on lines
9379
to
9387
| - func: lu_unpack(Tensor LU_data, Tensor LU_pivots, bool unpack_data=True, bool unpack_pivots=True) -> (Tensor P, Tensor L, Tensor U) | ||
| structured_delegate: lu_unpack.out | ||
| variants: function | ||
|
|
||
| - func: lu_unpack.out(Tensor LU_data, Tensor LU_pivots, bool unpack_data=True, bool unpack_pivots=True, *, Tensor(a!) P, Tensor(b!) L, Tensor(c!) U) -> (Tensor(a!) P, Tensor(b!) L, Tensor(c!) U) | ||
| variants: function | ||
| structured: True | ||
| dispatch: | ||
| CPU, CUDA: lu_unpack_out |
There was a problem hiding this comment.
@huiyan2021 Some missing code, right? Found in the commit enable _linalg_det and _linalg_det.result on xpu.
CuiYifeng
force-pushed
the
huiyan/linalg_det
branch
from
a37b03e to
aadfc3a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables optimized XPU support for linalg determinant, sign-logdet, and solve_ex functions by registering new dispatch entries and removing legacy fallback implementations.
- Added dispatch entries with structured delegates for _linalg_det, _linalg_slogdet, and _linalg_solve_ex in yaml/native/native_functions.yaml.
- Removed corresponding fallback entries and updated the test skip list in test/xpu/skip_list_common.py to reflect that these operations are now supported on XPU.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| yaml/native/native_functions.yaml | Introduced new dispatch entries and structured delegates for determinant, slogdet, and solve_ex operations. |
| test/xpu/skip_list_common.py | Removed skip list entries for linalg_det, linalg_slogdet, and linalg_solve_ex tests. |
Files not reviewed (1)
- src/ATen/native/xpu/XPUFallback.template: Language not supported
CuiYifeng
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request stacks on #1563. It introduces support for
_linalg_det,_linalg_slogdetand_linalg_solve_exrelated operations on XPU devices:_linalg_det&_linalg_det.result_linalg_slogdet&_linalg_slogdet.sign_linalg_solve_ex.resultIt also removes fallback implementations for these operations in favor of optimized XPU-specific implementations. Corresponding tests have been updated to reflect the new support.
New XPU Kernel Implementations:
Since
_linalg_det,_linalg_slogdetand_linalg_solve_excalllinalg_lu_factor_ex.outunderneath, which has been implemented in #1563, no new kernels need to be added in this pull request. Only dispatching these operations inthird_party/torch-xpu-ops/yaml/native/native_functions.yamlwould work.Removal of Fallbacks:
Removed fallback entries for
_linalg_det,_linalg_slogdetand_linalg_solve_exrelated operations fromthird_party/torch-xpu-ops/src/ATen/native/xpu/XPUFallback.template. These operations now have dedicated XPU implementations.Test Adjustments:
Updated the skip list in
test/xpu/skip_list_common.pyto remove passed and removedlinalg_det,linalg_slogdetand_linalg_solve_exrelated UTs.Fix #1597