Skip to content

Enable _linalg_det, _linalg_slogdet and _linalg_solve_ex related operations on xpu #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/ATen/native/xpu/XPUFallback.template
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ TORCH_LIBRARY_IMPL(aten, XPU, m) {
"_flash_attention_forward",
"geqrf",
"linalg_cholesky_ex.L",
"_linalg_det.result",
"linalg_eig",
"_linalg_eigvals",
"linalg_eigvals.out",
Expand All @@ -206,8 +205,6 @@ TORCH_LIBRARY_IMPL(aten, XPU, m) {
"linalg_lu.out",
"linalg_matrix_exp",
"linalg_qr.out",
"_linalg_slogdet.sign",
"_linalg_solve_ex.result",
"linalg_solve_triangular",
"_linalg_svd.U",
"lu_unpack.out",
Expand Down
55 changes: 0 additions & 55 deletions test/xpu/skip_list_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@
"test_errors_dot_xpu",
"test_errors_vdot_xpu",
# Linalg OPs not supported
"test_noncontiguous_samples_linalg_det_xpu_float32",
"test_noncontiguous_samples_linalg_slogdet_xpu_float32",
"test_noncontiguous_samples_linalg_solve_ex_xpu_float32",
"test_noncontiguous_samples_linalg_solve_xpu_float32",
"test_noncontiguous_samples_linalg_tensorsolve_xpu_float32",
"test_noncontiguous_samples_logdet_xpu_float32",
# Sparse CSR OPs not supported
Expand Down Expand Up @@ -133,7 +129,6 @@
"test_dtypes_linalg_cholesky_ex_xpu",
"test_dtypes_linalg_cholesky_xpu",
"test_dtypes_linalg_cond_xpu",
"test_dtypes_linalg_det_singular_xpu",
"test_dtypes_linalg_det_xpu",
"test_dtypes_linalg_eig_xpu",
"test_dtypes_linalg_eigh_xpu",
Expand Down Expand Up @@ -281,7 +276,6 @@
"test_out_requires_grad_error_inner_xpu_complex64",
"test_out_requires_grad_error_linalg_cholesky_ex_xpu_complex64",
"test_out_requires_grad_error_linalg_cholesky_xpu_complex64",
"test_out_requires_grad_error_linalg_det_singular_xpu_complex64",
"test_out_requires_grad_error_linalg_eig_xpu_complex64",
"test_out_requires_grad_error_linalg_eigh_xpu_complex64",
"test_out_requires_grad_error_linalg_eigvals_xpu_complex64",
Expand Down Expand Up @@ -350,7 +344,6 @@
"test_variant_consistency_eager_linalg_cholesky_ex_xpu_complex64",
"test_variant_consistency_eager_linalg_cholesky_xpu_complex64",
"test_variant_consistency_eager_linalg_cond_xpu_complex64",
"test_variant_consistency_eager_linalg_det_singular_xpu_complex64",
"test_variant_consistency_eager_linalg_det_xpu_complex64",
"test_variant_consistency_eager_linalg_eig_xpu_complex64",
"test_variant_consistency_eager_linalg_eigh_xpu_complex64",
Expand Down Expand Up @@ -425,7 +418,6 @@
"test_conj_view_linalg_cholesky_ex_xpu_complex64",
"test_conj_view_linalg_cholesky_xpu_complex64",
"test_conj_view_linalg_cond_xpu_complex64",
"test_conj_view_linalg_det_singular_xpu_complex64",
"test_conj_view_linalg_det_xpu_complex64",
"test_conj_view_linalg_eig_xpu_complex64",
"test_conj_view_linalg_eigh_xpu_complex64",
Expand Down Expand Up @@ -490,7 +482,6 @@
"test_neg_conj_view_linalg_cholesky_ex_xpu_complex128",
"test_neg_conj_view_linalg_cholesky_xpu_complex128",
"test_neg_conj_view_linalg_cond_xpu_complex128",
"test_neg_conj_view_linalg_det_singular_xpu_complex128",
"test_neg_conj_view_linalg_eig_xpu_complex128",
"test_neg_conj_view_linalg_eigh_xpu_complex128",
"test_neg_conj_view_linalg_eigvals_xpu_complex128",
Expand Down Expand Up @@ -551,8 +542,6 @@
"test_neg_view_linalg_cholesky_ex_xpu_float64",
"test_neg_view_linalg_cholesky_xpu_float64",
"test_neg_view_linalg_cond_xpu_float64",
"test_neg_view_linalg_det_singular_xpu_float64",
"test_neg_view_linalg_det_xpu_float64",
"test_neg_view_linalg_eig_xpu_float64",
"test_neg_view_linalg_eigh_xpu_float64",
"test_neg_view_linalg_eigvalsh_xpu_float64",
Expand All @@ -575,10 +564,7 @@
"test_neg_view_linalg_pinv_singular_xpu_float64",
"test_neg_view_linalg_pinv_xpu_float64",
"test_neg_view_linalg_qr_xpu_float64",
"test_neg_view_linalg_slogdet_xpu_float64",
"test_neg_view_linalg_solve_ex_xpu_float64",
"test_neg_view_linalg_solve_triangular_xpu_float64",
"test_neg_view_linalg_solve_xpu_float64",
"test_neg_view_linalg_svd_xpu_float64",
"test_neg_view_linalg_svdvals_xpu_float64",
"test_neg_view_linalg_tensorinv_xpu_float64",
Expand Down Expand Up @@ -1279,8 +1265,6 @@
"test_corner_cases_of_cublasltmatmul_xpu_complex128",
"test_corner_cases_of_cublasltmatmul_xpu_complex64",
"test_corner_cases_of_cublasltmatmul_xpu_float64",
"test_det_logdet_slogdet_batched_xpu_float64",
"test_det_logdet_slogdet_xpu_float64",
"test_eig_check_magma_xpu_float32",
"test_einsum_random_xpu_complex128",
"test_einsum_random_xpu_float64",
Expand Down Expand Up @@ -1378,7 +1362,6 @@
"test_pinverse_xpu_float64",
"test_slogdet_xpu_complex128",
"test_slogdet_xpu_complex64",
"test_slogdet_xpu_float64",
"test_solve_batched_broadcasting_xpu_complex128",
"test_solve_batched_broadcasting_xpu_complex64",
"test_solve_batched_broadcasting_xpu_float64",
Expand Down Expand Up @@ -1523,7 +1506,6 @@
"test_fn_fwgrad_bwgrad_linalg_cond_xpu_complex128",
"test_fn_fwgrad_bwgrad_linalg_cond_xpu_float64",
"test_fn_fwgrad_bwgrad_linalg_det_xpu_complex128",
"test_fn_fwgrad_bwgrad_linalg_det_xpu_float64",
"test_fn_fwgrad_bwgrad_linalg_eig_xpu_complex128",
"test_fn_fwgrad_bwgrad_linalg_eig_xpu_float64",
"test_fn_fwgrad_bwgrad_linalg_eigh_xpu_complex128",
Expand Down Expand Up @@ -1560,13 +1542,10 @@
"test_fn_fwgrad_bwgrad_linalg_qr_xpu_complex128",
"test_fn_fwgrad_bwgrad_linalg_qr_xpu_float64",
"test_fn_fwgrad_bwgrad_linalg_slogdet_xpu_complex128",
"test_fn_fwgrad_bwgrad_linalg_slogdet_xpu_float64",
"test_fn_fwgrad_bwgrad_linalg_solve_ex_xpu_complex128",
"test_fn_fwgrad_bwgrad_linalg_solve_ex_xpu_float64",
"test_fn_fwgrad_bwgrad_linalg_solve_triangular_xpu_complex128",
"test_fn_fwgrad_bwgrad_linalg_solve_triangular_xpu_float64",
"test_fn_fwgrad_bwgrad_linalg_solve_xpu_complex128",
"test_fn_fwgrad_bwgrad_linalg_solve_xpu_float64",
"test_fn_fwgrad_bwgrad_linalg_svd_xpu_complex128",
"test_fn_fwgrad_bwgrad_linalg_svd_xpu_float64",
"test_fn_fwgrad_bwgrad_linalg_svdvals_xpu_complex128",
Expand Down Expand Up @@ -1638,10 +1617,7 @@
"test_forward_mode_AD_linalg_cholesky_xpu_float64",
"test_forward_mode_AD_linalg_cond_xpu_complex128",
"test_forward_mode_AD_linalg_cond_xpu_float64",
"test_forward_mode_AD_linalg_det_singular_xpu_complex128",
"test_forward_mode_AD_linalg_det_singular_xpu_float64",
"test_forward_mode_AD_linalg_det_xpu_complex128",
"test_forward_mode_AD_linalg_det_xpu_float64",
"test_forward_mode_AD_linalg_eig_xpu_complex128",
"test_forward_mode_AD_linalg_eig_xpu_float64",
"test_forward_mode_AD_linalg_eigh_xpu_complex128",
Expand Down Expand Up @@ -1679,13 +1655,10 @@
"test_forward_mode_AD_linalg_qr_xpu_complex128",
"test_forward_mode_AD_linalg_qr_xpu_float64",
"test_forward_mode_AD_linalg_slogdet_xpu_complex128",
"test_forward_mode_AD_linalg_slogdet_xpu_float64",
"test_forward_mode_AD_linalg_solve_ex_xpu_complex128",
"test_forward_mode_AD_linalg_solve_ex_xpu_float64",
"test_forward_mode_AD_linalg_solve_triangular_xpu_complex128",
"test_forward_mode_AD_linalg_solve_triangular_xpu_float64",
"test_forward_mode_AD_linalg_solve_xpu_complex128",
"test_forward_mode_AD_linalg_solve_xpu_float64",
"test_forward_mode_AD_linalg_svd_xpu_complex128",
"test_forward_mode_AD_linalg_svd_xpu_float64",
"test_forward_mode_AD_linalg_svdvals_xpu_complex128",
Expand Down Expand Up @@ -1871,10 +1844,7 @@
"test_fn_grad_linalg_cholesky_xpu_float64",
"test_fn_grad_linalg_cond_xpu_complex128",
"test_fn_grad_linalg_cond_xpu_float64",
"test_fn_grad_linalg_det_singular_xpu_complex128",
"test_fn_grad_linalg_det_singular_xpu_float64",
"test_fn_grad_linalg_det_xpu_complex128",
"test_fn_grad_linalg_det_xpu_float64",
"test_fn_grad_linalg_eig_xpu_complex128",
"test_fn_grad_linalg_eig_xpu_float64",
"test_fn_grad_linalg_eigh_xpu_complex128",
Expand Down Expand Up @@ -1911,13 +1881,10 @@
"test_fn_grad_linalg_qr_xpu_complex128",
"test_fn_grad_linalg_qr_xpu_float64",
"test_fn_grad_linalg_slogdet_xpu_complex128",
"test_fn_grad_linalg_slogdet_xpu_float64",
"test_fn_grad_linalg_solve_ex_xpu_complex128",
"test_fn_grad_linalg_solve_ex_xpu_float64",
"test_fn_grad_linalg_solve_triangular_xpu_complex128",
"test_fn_grad_linalg_solve_triangular_xpu_float64",
"test_fn_grad_linalg_solve_xpu_complex128",
"test_fn_grad_linalg_solve_xpu_float64",
"test_fn_grad_linalg_svd_xpu_complex128",
"test_fn_grad_linalg_svd_xpu_float64",
"test_fn_grad_linalg_svdvals_xpu_complex128",
Expand Down Expand Up @@ -1992,7 +1959,6 @@
"test_fn_gradgrad_linalg_cond_xpu_complex128",
"test_fn_gradgrad_linalg_cond_xpu_float64",
"test_fn_gradgrad_linalg_det_xpu_complex128",
"test_fn_gradgrad_linalg_det_xpu_float64",
"test_fn_gradgrad_linalg_eig_xpu_complex128",
"test_fn_gradgrad_linalg_eig_xpu_float64",
"test_fn_gradgrad_linalg_eigh_xpu_complex128",
Expand Down Expand Up @@ -2028,13 +1994,10 @@
"test_fn_gradgrad_linalg_qr_xpu_complex128",
"test_fn_gradgrad_linalg_qr_xpu_float64",
"test_fn_gradgrad_linalg_slogdet_xpu_complex128",
"test_fn_gradgrad_linalg_slogdet_xpu_float64",
"test_fn_gradgrad_linalg_solve_ex_xpu_complex128",
"test_fn_gradgrad_linalg_solve_ex_xpu_float64",
"test_fn_gradgrad_linalg_solve_triangular_xpu_complex128",
"test_fn_gradgrad_linalg_solve_triangular_xpu_float64",
"test_fn_gradgrad_linalg_solve_xpu_complex128",
"test_fn_gradgrad_linalg_solve_xpu_float64",
"test_fn_gradgrad_linalg_svd_xpu_complex128",
"test_fn_gradgrad_linalg_svd_xpu_float64",
"test_fn_gradgrad_linalg_svdvals_xpu_complex128",
Expand Down Expand Up @@ -2359,10 +2322,7 @@
"test_dispatch_meta_outplace_linalg_cholesky_ex_xpu_float64",
"test_dispatch_meta_outplace_linalg_cholesky_xpu_complex",
"test_dispatch_meta_outplace_linalg_cholesky_xpu_float64",
"test_dispatch_meta_outplace_linalg_det_singular_xpu_complex",
"test_dispatch_meta_outplace_linalg_det_singular_xpu_float64",
"test_dispatch_meta_outplace_linalg_det_xpu_complex",
"test_dispatch_meta_outplace_linalg_det_xpu_float64",
"test_dispatch_meta_outplace_linalg_eig_xpu_complex",
"test_dispatch_meta_outplace_linalg_eig_xpu_float64",
"test_dispatch_meta_outplace_linalg_eigh_xpu_complex",
Expand Down Expand Up @@ -2403,11 +2363,8 @@
"test_dispatch_meta_outplace_linalg_qr_xpu_complex",
"test_dispatch_meta_outplace_linalg_qr_xpu_float64",
"test_dispatch_meta_outplace_linalg_slogdet_xpu_complex",
"test_dispatch_meta_outplace_linalg_slogdet_xpu_float64",
"test_dispatch_meta_outplace_linalg_solve_ex_xpu_complex",
"test_dispatch_meta_outplace_linalg_solve_ex_xpu_float64",
"test_dispatch_meta_outplace_linalg_solve_xpu_complex",
"test_dispatch_meta_outplace_linalg_solve_xpu_float64",
"test_dispatch_meta_outplace_linalg_svd_xpu_complex",
"test_dispatch_meta_outplace_linalg_svd_xpu_float64",
"test_dispatch_meta_outplace_linalg_tensorinv_xpu_complex",
Expand Down Expand Up @@ -2485,10 +2442,7 @@
"test_dispatch_symbolic_meta_outplace_linalg_cholesky_ex_xpu_float64",
"test_dispatch_symbolic_meta_outplace_linalg_cholesky_xpu_complex",
"test_dispatch_symbolic_meta_outplace_linalg_cholesky_xpu_float64",
"test_dispatch_symbolic_meta_outplace_linalg_det_singular_xpu_complex",
"test_dispatch_symbolic_meta_outplace_linalg_det_singular_xpu_float64",
"test_dispatch_symbolic_meta_outplace_linalg_det_xpu_complex",
"test_dispatch_symbolic_meta_outplace_linalg_det_xpu_float64",
"test_dispatch_symbolic_meta_outplace_linalg_eig_xpu_complex",
"test_dispatch_symbolic_meta_outplace_linalg_eig_xpu_float64",
"test_dispatch_symbolic_meta_outplace_linalg_eigh_xpu_complex",
Expand Down Expand Up @@ -2529,11 +2483,8 @@
"test_dispatch_symbolic_meta_outplace_linalg_qr_xpu_complex",
"test_dispatch_symbolic_meta_outplace_linalg_qr_xpu_float64",
"test_dispatch_symbolic_meta_outplace_linalg_slogdet_xpu_complex",
"test_dispatch_symbolic_meta_outplace_linalg_slogdet_xpu_float64",
"test_dispatch_symbolic_meta_outplace_linalg_solve_ex_xpu_complex",
"test_dispatch_symbolic_meta_outplace_linalg_solve_ex_xpu_float64",
"test_dispatch_symbolic_meta_outplace_linalg_solve_xpu_complex",
"test_dispatch_symbolic_meta_outplace_linalg_solve_xpu_float64",
"test_dispatch_symbolic_meta_outplace_linalg_svd_xpu_complex",
"test_dispatch_symbolic_meta_outplace_linalg_svd_xpu_float64",
"test_dispatch_symbolic_meta_outplace_linalg_tensorinv_xpu_complex",
Expand Down Expand Up @@ -2611,10 +2562,7 @@
"test_meta_outplace_linalg_cholesky_ex_xpu_float64",
"test_meta_outplace_linalg_cholesky_xpu_complex",
"test_meta_outplace_linalg_cholesky_xpu_float64",
"test_meta_outplace_linalg_det_singular_xpu_complex",
"test_meta_outplace_linalg_det_singular_xpu_float64",
"test_meta_outplace_linalg_det_xpu_complex",
"test_meta_outplace_linalg_det_xpu_float64",
"test_meta_outplace_linalg_eig_xpu_complex",
"test_meta_outplace_linalg_eig_xpu_float64",
"test_meta_outplace_linalg_eigh_xpu_complex",
Expand Down Expand Up @@ -2655,11 +2603,8 @@
"test_meta_outplace_linalg_qr_xpu_complex",
"test_meta_outplace_linalg_qr_xpu_float64",
"test_meta_outplace_linalg_slogdet_xpu_complex",
"test_meta_outplace_linalg_slogdet_xpu_float64",
"test_meta_outplace_linalg_solve_ex_xpu_complex",
"test_meta_outplace_linalg_solve_ex_xpu_float64",
"test_meta_outplace_linalg_solve_xpu_complex",
"test_meta_outplace_linalg_solve_xpu_float64",
"test_meta_outplace_linalg_svd_xpu_complex",
"test_meta_outplace_linalg_svd_xpu_float64",
"test_meta_outplace_linalg_tensorinv_xpu_complex",
Expand Down
58 changes: 58 additions & 0 deletions yaml/native/native_functions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9375,3 +9375,61 @@
structured: True
dispatch:
XPU: linalg_lu_solve_out

# linalg.det
- func: _linalg_det(Tensor A) -> (Tensor result, Tensor LU, Tensor pivots)
structured_delegate: _linalg_det.result

- func: _linalg_det.result(Tensor A, *, Tensor(a!) result, Tensor(b!) LU, Tensor(c!) pivots) -> (Tensor(a!) result, Tensor(b!) LU, Tensor(c!) pivots)
structured: True
dispatch:
XPU: _linalg_det_out

- func: linalg_det(Tensor A) -> Tensor
python_module: linalg
variants: function

- func: linalg_det.out(Tensor A, *, Tensor(a!) out) -> Tensor(a!)
python_module: linalg

# torch.det, alias for torch.linalg.det
- func: det(Tensor self) -> Tensor
variants: function, method

# linalg.slogdet
- func: _linalg_slogdet(Tensor A) -> (Tensor sign, Tensor logabsdet, Tensor LU, Tensor pivots)
structured_delegate: _linalg_slogdet.sign

- func: _linalg_slogdet.sign(Tensor A, *, Tensor(a!) sign, Tensor(b!) logabsdet, Tensor(c!) LU, Tensor(d!) pivots) -> (Tensor(a!) sign, Tensor(b!) logabsdet, Tensor(c!) LU, Tensor(d!) pivots)
structured: True
dispatch:
XPU: _linalg_slogdet_out

- func: linalg_slogdet(Tensor A) -> (Tensor sign, Tensor logabsdet)
python_module: linalg

- func: linalg_slogdet.out(Tensor A, *, Tensor(a!) sign, Tensor(b!) logabsdet) -> (Tensor(a!) sign, Tensor(b!) logabsdet)
python_module: linalg

- func: slogdet(Tensor self) -> (Tensor sign, Tensor logabsdet)
variants: function, method

- func: slogdet.out(Tensor self, *, Tensor(a!) sign, Tensor(b!) logabsdet) -> (Tensor(a!) sign, Tensor(b!) logabsdet)
variants: function

- func: _linalg_solve_ex(Tensor A, Tensor B, *, bool left=True, bool check_errors=False) -> (Tensor result, Tensor LU, Tensor pivots, Tensor info)
structured_delegate: _linalg_solve_ex.result

- func: _linalg_solve_ex.result(Tensor A, Tensor B, *, bool left=True, bool check_errors=False, Tensor(a!) result, Tensor(b!) LU, Tensor(c!) pivots, Tensor(d!) info) -> (Tensor(a!) result, Tensor(b!) LU, Tensor(c!) pivots, Tensor(d!) info)
structured: True
dispatch:
XPU: _linalg_solve_ex_out

- func: linalg_solve_ex(Tensor A, Tensor B, *, bool left=True, bool check_errors=False) -> (Tensor result, Tensor info)
python_module: linalg

- func: linalg_solve_ex.out(Tensor A, Tensor B, *, bool left=True, bool check_errors=False, Tensor(a!) result, Tensor(b!) info) -> (Tensor(a!) result, Tensor(b!) info)
python_module: linalg

- func: linalg_solve(Tensor A, Tensor B, *, bool left=True) -> Tensor
python_module: linalg