sample finetuning script updated #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
scripts/Sample_ft.ipynb:250
- Slicing the response lines starting from index 4 may be unreliable if the response format changes. Consider using a more robust method to extract the hypothesis.
hypothesis = "\n".join(lines[4:])
| " return_tensors = \"pt\",\n", | ||
| " ).to(\"cuda\")\n", | ||
| "\n", | ||
| " from transformers import TextStreamer\n", |
There was a problem hiding this comment.
[nitpick] Importing TextStreamer inside the loop could impact performance due to repeated imports. Consider moving this import outside the loop.
Suggested change
| " from transformers import TextStreamer\n", |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.