-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Create 2.528.1 changelog and upgrade guide #8458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 2.528.1 changelog and upgrade guide #8458
Conversation
@kmartens27 the upgrade guide needs to mention that users of the timestamper plugin must upgrade to the correct version before upgrading to Jenkins 2.528.1. Also, we need to note in the upgrade guide and in the changelog that the container images based on Debian are now using Debian 13 ("Trixie") instead of Debian 12 ("bookworm"). |
WDYT about also mentionning the availability of JDK25 images for all agents (pending jenkinsci/docker-ssh-agent#549), and for the controller (pending jenkinsci/docker#2072 - this one might not make the cut for the 15th October release, tests are failing and require additional work) |
I'm hesitant to mention Java 25 support in this LTS because Jenkins 2.528.1 requires the command line flag to allow Java 25 to run. I don't expect LTS users to experiment with new Java versions as readily as weekly users and weekly users still must use the command line flag. Let's wait a quarter for the Jan 2026 LTS release and hope that we're ready to announce Java 25 support at that time. |
TIL. Make sense to wait then. Do you have more info or references about that flag by any chance? |
Sure. When I try to run a current Jenkins version (up to 2.530) with Java 25, I see the following output:
|
Got it, tried a build with this option but it fails. Needs jenkinsci/jenkins#11148 Thanks for the info! |
Hi @MarkEWaite, thanks for the feedback and providing the screenshots! I've updated the upgrade guide to have two additional entries (for trixie and timestamper), and made sure to add the Debian update to the changelog. Please let me know if those are sufficient or if any of the uprade guide text needs to be adjusted before this can be merged! |
The additions are valuable but the changelog is focused on the user and their experience rather than internal changes.
Debian container image phrasing changes. Other minor changes to phrasing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @kmartens27 I made several changes and pushed them directly to your branch. If any of them need changes or should be removed, let me know and I'll make the changes.
@lemeurherve this is ready for another review by you as well.
@MarkEWaite I think your push failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some optional comments & questions.
content/_data/changelogs/lts.yml
Outdated
pr_title: "Remove net.i2p.crypto:eddsa which is not supported anymore and | ||
use support of EdDSA natively provided now by Apache Mina via Bouncycastle" | ||
message: |- | ||
SSH cli now uses support of EdDSA natively provided by Apache Mina via Bouncycastle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"uses support of" sounds a bit strange to my ears, then it might just be me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good observation. Fixed in 5f9a2bb
pr_title: "[JENKINS-75991] Fix name of reason query parameter in online help | ||
for quietDown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr_title: "[JENKINS-75991] Fix name of reason query parameter in online help | |
for quietDown" | |
pr_title: "[JENKINS-75991] Fix name of reason query parameter in online help for quietDown" |
Is there a rule for having long PR titles on multiple lines? If not, suggesting putting it on a single line (nit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically the longer titles get formatted in this way where the last few words/later half of the title are moved to the next line as so. There's not necessarily any rule saying it can't be on one line as far as I'm aware. The weekly automation usually splits the title & message in such a way if it's longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core changelog generator creates the PR title that way and we rely on it to retain the same formatting. I don't plan to change this one.
pr_title: When a pending item lost its executor, it should be | ||
rescheduled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr_title: When a pending item lost its executor, it should be | |
rescheduled | |
pr_title: When a pending item lost its executor, it should be rescheduled |
Same as above (nit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change, same as above
==== Configuration as code entry for 'myViewsTabBar' is deprecated. | ||
|
||
As of 2.528.1, the configuration as code entry for 'myViewsTabBar' has been deprecated. | ||
In its place, a new user property has been introduced that makes it possible for a user to override what is configured for the global dashboard or a folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the new user property name be mentioned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was looking to add this entry I think I may have missed the property. It can definitely be updated to share the actual name of the property though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The property is modified by the user through the Jenkins web pages, without needing to know the name of the property. Sharing the name of the property with the user won't help them in this case,
This PR is to create the changelog & upgrade guide for 2.528.1. The upgrade guide only contains 1 entry at this time based on the Jenkins github issues list. It has been compared to the already released changelogs to prevent any duplicate entries.
Changelog
Upgrade Guide