-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(linux): add support on Linux for JDK 25 preview in Docker build configurations #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linux): add support on Linux for JDK 25 preview in Docker build configurations #2072
Conversation
…ate-jlink-modules-default
…github.com/gounthar/docker into refactor/deduplicate-jlink-modules-default
…ate-jlink-modules-default
"21."*) set -- "--compress=zip-6" ;; \ | ||
"21."*) set -- "--compress=zip-6" "--add-modules" "ALL-MODULE-PATH" ;; \ | ||
# the compression argument is different for JDK25 (early access) | ||
"25"*) mod_list="${JLINK_MODULES:-$JLINK_MODULES_DEFAULT}"; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: what's the purpose of having two variables for jlink modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal was to have JLINK_MODULES
configurable via the command line if needed, but it may be unneeded complexity. 🤔
On 22 tests, 9 failures: https://ci.jenkins.io/job/Packaging/job/docker/job/PR-2072/13/testReport/ I suggest using |
Strange, all was working fine on my end when I last committed... 🤔 |
Cf your current "testing done", I don't doubt If not, can you try it now please? |
I found out Jenkins controller isn't compatible with Java 25 yet cf jenkins-infra/jenkins.io#8458 (comment) As this might take some time, maybe close this PR meanwhile and restart a fresh one when compatible? |
I had |
Getting the docker image to build is one thing, getting it to work and passes tests is what matters 😉 Have you tried EDIT:
You can (I'd even say "have to") run tests locally before submitting a pull request for review. |
Summary
Changes Made
JDK 25 Support
docker-bake.hcl
with JDK 25 targets across all supported platforms25+9-ea-beta
Build System Improvements
"$@"
for proper parameter expansionPlatform Support
Testing done
make build
Submitter checklist