SYM-7135: Added H2 SYM_DATA_DATA_ID_SEQ sequence if missing during an upgrade #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pavel-jm
reviewed
Nov 19, 2025
| engine.getNodeId(), engine.getNodeId()); | ||
| } | ||
| if (engine.getDatabasePlatform().getName().equals(DatabaseNamesConstants.H2)) { | ||
| String dataIdSequenceName = symmetricDialect.getSequenceName(SequenceIdentifier.DATA).toUpperCase() + "_SEQ"; |
Contributor
There was a problem hiding this comment.
This code block is large yet it applies only to H2 database. One way to improve readability (and test-ability) is to move code to a separate utility method.
Another path to consider is a new H2-specific upgrade listener class?
(We can review this in our Thursday meeting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would have been good to limit the
information_schema.sequencesquery to only run on an upgrade from 3.16.7 or earlier. Usually there's a check for a particular schema change to determine the version that is being upgraded from, but there are no schema changes in the upgrade from an earlier 3.16 version to 3.16.8.If it isn't okay to run this query every time an H2 node is upgraded, then I could make this change in 3.17.0 instead or I could try checking
sym_node.symmetric_versioninstead of relying on a schema change.