Skip to content

SYM-7135: Added H2 SYM_DATA_DATA_ID_SEQ sequence if missing during an upgrade #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/3.16
Choose a base branch
from
Open

SYM-7135: Added H2 SYM_DATA_DATA_ID_SEQ sequence if missing during an upgrade #460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions symmetric-core/src/main/java/org/jumpmind/symmetric/db/DatabaseUpgradeListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,33 @@ public String afterUpgrade(ISymmetricDialect symmetricDialect, String tablePrefi
+ " where source_node_id = ? and completed = 1)",
engine.getNodeId(), engine.getNodeId());
}
if (engine.getDatabasePlatform().getName().equals(DatabaseNamesConstants.H2)) {
String dataIdSequenceName = symmetricDialect.getSequenceName(SequenceIdentifier.DATA).toUpperCase() + "_SEQ";
Copy link
Contributor

@pavel-jm pavel-jm Nov 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block is large yet it applies only to H2 database. One way to improve readability (and test-ability) is to move code to a separate utility method.
Another path to consider is a new H2-specific upgrade listener class?
(We can review this in our Thursday meeting)

if (engine.getSqlTemplate().queryForInt("select count(*) from information_schema.sequences where sequence_name = ?", dataIdSequenceName) == 0) {
String dataTableName = TableConstants.getTableName(tablePrefix, TableConstants.SYM_DATA);
ISqlTransaction transaction = null;
try {
transaction = engine.getSqlTemplate().startSqlTransaction();
transaction.prepareAndExecute("set exclusive 1");
long maxDataId = Math.max(transaction.queryForInt("select max(data_id) from " + dataTableName), 1);
log.info("After upgrade, creating {} sequence with a value of {} because it doesn't exist", dataIdSequenceName, maxDataId + 1);
transaction.prepareAndExecute("create sequence \"" + dataIdSequenceName + "\" start with " + (maxDataId + 1));
log.info("After upgrade, altering {}.data_id to use the new sequence instead of auto_increment", dataTableName);
transaction.prepareAndExecute("alter table " + dataTableName
+ " alter column data_id bigint not null default nextval('" + dataIdSequenceName + "')");
transaction.prepareAndExecute("set exclusive 0");
} catch (Exception e) {
log.info("Unable to create sequence: {}", e.getMessage());
if (transaction != null) {
transaction.rollback();
}
} finally {
if (transaction != null) {
transaction.close();
}
}
}
}
engine.getPullService().pullConfigData(false);
return sb.toString();
}
Expand Down
Loading