Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing nvars in addCorGen #212

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Fixing nvars in addCorGen #212

merged 1 commit into from
Aug 10, 2023

Conversation

kgoldfeld
Copy link
Owner

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2f7a2b1 is merged into main:

  •   :ballot_box_with_check:define_data: 19.8ms -> 20ms [-0.46%, +2.45%]
  •   :ballot_box_with_check:dist_beta: 259ms -> 258ms [-0.79%, +0.39%]
  •   :ballot_box_with_check:dist_binary: 13.8ms -> 13.9ms [-0.68%, +1.7%]
  •   :ballot_box_with_check:dist_binomial: 18.5ms -> 18.5ms [-1.18%, +1.13%]
  • ❗🐌dist_categorical: 84.4ms -> 84.9ms [+0.07%, +1.13%]
  •   :ballot_box_with_check:dist_exponential: 13.9ms -> 13.8ms [-1.58%, +0.68%]
  •   :ballot_box_with_check:dist_gamma: 25.4ms -> 25.4ms [-0.48%, +0.73%]
  •   :ballot_box_with_check:dist_mixture: 279ms -> 278ms [-0.53%, +0.27%]
  •   :ballot_box_with_check:dist_normal: 16.6ms -> 16.8ms [-0.61%, +1.85%]
  •   :ballot_box_with_check:gen_all_dists: 65.4ms -> 65.3ms [-1.43%, +1.29%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@kgoldfeld kgoldfeld marked this pull request as ready for review August 10, 2023 00:57
@kgoldfeld kgoldfeld merged commit d40d33d into main Aug 10, 2023
11 checks passed
@kgoldfeld kgoldfeld deleted the issue-208-improve-addCorGen branch August 10, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant