Add big number exception handling, off-by-one in Int/Long handling (not serious), and version bump #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwhite
commented
Jan 21, 2011
bwhite
commented
- Big number exception handling (previous didn't support anything outside of [-263, 263-1])
- Off-by-one in Int/Long handling. This is not serious, one number in each range would have been a pickle instead of an integer type; however, it's good to have it be clear what ranges become pickles and what ranges become native ints
- Version bump
…re, assumes it is overflow for speed). It clears the error and falls back to Pickle. Signed-off-by: Brandyn A. White <[email protected]>
…being missed) should be [-2**31, 2**31-1] and [-2**63, 2**63-1] was [-2**31+1, 2**31-1] and [-2**63+1, 2**63-1] Signed-off-by: Brandyn A. White <[email protected]>
Signed-off-by: Brandyn A. White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.