Skip to content

Add big number exception handling, off-by-one in Int/Long handling (not serious), and version bump #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bwhite wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add big number exception handling, off-by-one in Int/Long handling (not serious), and version bump #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b363431
Added error check in longlong handeling (only one error can occur the…
bwhite Jan 21, 2011
3eacc71
Corrected lower end of the integer checks (lowest possible value was …
bwhite Jan 21, 2011
b97406b
Version bump
bwhite Jan 21, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions fastb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ _fastb_read_pyobj_int(FILE *stream, PyObject *fallback) {
static int
_fastb_write_pyobj_int(FILE *stream, PyObject *pyobj, PyObject *fallback) {
long l = PyInt_AS_LONG(pyobj);
if (-2147483647L <= l && l <= 2147483647L) {
if (-2147483648L <= l && l <= 2147483647L) {
return _fastb_write_int(stream, l);
} else {
return _fastb_write_long(stream, l);
Expand All @@ -235,9 +235,10 @@ _fastb_read_pyobj_long(FILE *stream, PyObject *fallback) {
static int
_fastb_write_pyobj_long(FILE *stream, PyObject *pyobj, PyObject *fallback) {
long long l = PyLong_AsLongLong(pyobj);
if (-9223372036854775807LL <= l && l <= 9223372036854775807LL) {
if (!PyErr_Occurred() && -9223372036854775808LL <= l && l <= 9223372036854775807LL) {
return _fastb_write_long(stream, l);
} else {
PyErr_Clear();
return _fastb_write_pyobj_fallback(stream, pyobj, fallback);
}
}
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from setuptools import setup, Extension
setup(name='ctypedbytes',
version='0.1.7',
version='0.1.8',
description='A fast Python module for dealing with so called "typed bytes"',
author='Klaas Bosteels',
author_email='klaas@last.fm',
Expand Down