Improve the node package list updates #17704
Conversation
k8s-ci-robot
added
cncf-cla: yes
hakman
force-pushed
the
update-packages
branch
from
8117d4c to
fa387db
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold |
k8s-ci-robot
added
size/M
hakman
force-pushed
the
update-packages
branch
from
a635d2e to
f85467e
Compare
Signed-off-by: Ciprian Hacman <[email protected]>
hakman
force-pushed
the
update-packages
branch
from
f85467e to
26f7013
Compare
|
/approve |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| // If it is newer than 10 minutes, we skip apt-get update. | ||
| stat, err := os.Stat("/var/lib/dpkg/status") | ||
| // If the package manager update was less than 10 minutes ago, skip updating the package list. | ||
| if d.IsDebianFamily() && time.Since(packageManagerLastUpdated) > 10*time.Minute { |
There was a problem hiding this comment.
Why 10 min ? I think apt update take less than 5 min to run.
There was a problem hiding this comment.
This is meant to run apt-get update every 10 min (arbitrary number). I expect bootstrap to finish much faster, but seems reasonable.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/override pull-kops-e2e-k8s-gce-cilium |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-cilium In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Addressing code review comments from #17690.
/cc @justinsb @ameukam @rifelpet