Skip to content

fix: update pr-creator #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Mar 25, 2025

What this PR does / why we need it:

Changes:

  • removes the fixed commit checkout from the test-infra to consume updates
  • adds the hack scripts to the image

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Changes:
* removes the fixed commit checkout from the test-infra to consume
  updates
* adds the hack scripts to the image

Signed-off-by: Daniel Hiller <[email protected]>
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 25, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enp0s3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@victortoso victortoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I know it is a draft but I saw it when handling my notifications...

The only suggestion I'd give (not to your patch but still) is to use git clone with --depth 1 to reduce fetch & size if you are not interested in git's history.


RUN set -x && \
git clone https://github.com/kubernetes/test-infra.git && \
cd ./test-infra && \
git checkout e4d87dae72dbf1754625cbf112afc535307c1db4 && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, git clone has --revision to pass a hash.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noted that this is a flag that has been added two minor versions ago from the latest - i.e. in an image i used it wasn't available yet.

@dhiller
Copy link
Contributor Author

dhiller commented Mar 25, 2025

Hi, I know it is a draft but I saw it when handling my notifications...

The only suggestion I'd give (not to your patch but still) is to use git clone with --depth 1 to reduce fetch & size if you are not interested in git's history.

@victortoso makes total sense - I forget to do that every time. Thanks for the nudge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants