-
Notifications
You must be signed in to change notification settings - Fork 146
fix: update pr-creator #4046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: update pr-creator #4046
Conversation
Changes: * removes the fixed commit checkout from the test-infra to consume updates * adds the hack scripts to the image Signed-off-by: Daniel Hiller <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I know it is a draft but I saw it when handling my notifications...
The only suggestion I'd give (not to your patch but still) is to use git clone
with --depth 1
to reduce fetch & size if you are not interested in git's history.
|
||
RUN set -x && \ | ||
git clone https://github.com/kubernetes/test-infra.git && \ | ||
cd ./test-infra && \ | ||
git checkout e4d87dae72dbf1754625cbf112afc535307c1db4 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, git clone
has --revision
to pass a hash
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noted that this is a flag that has been added two minor versions ago from the latest - i.e. in an image i used it wasn't available yet.
@victortoso makes total sense - I forget to do that every time. Thanks for the nudge! |
What this PR does / why we need it:
Changes:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: