Skip to content

fix: update pr-creator #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: update pr-creator #4046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions images/pr-creator/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
FROM quay.io/kubevirtci/golang:v20240814-9b6c4af

ENV GIMME_GO_VERSION=1.22.6
ENV GIMME_GO_VERSION=1.23.4

RUN set -x && \
git clone https://github.com/kubernetes/test-infra.git && \
cd ./test-infra && \
git checkout e4d87dae72dbf1754625cbf112afc535307c1db4 && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, git clone has --revision to pass a hash.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noted that this is a flag that has been added two minor versions ago from the latest - i.e. in an image i used it wasn't available yet.

/usr/local/bin/runner.sh /bin/sh -ce 'go build -o ./robots/pr-creator/pr-creator ./robots/pr-creator/main.go' && \
mv ./robots/pr-creator/pr-creator /usr/local/bin/ && \
chmod +x /usr/local/bin/pr-creator && \
Expand All @@ -15,9 +14,8 @@ RUN set -x && \
RUN set -x && \
git clone https://github.com/kubevirt/project-infra.git && \
cd ./project-infra && \
cp ./hack/git-askpass.sh /usr/local/bin && \
cp ./hack/git-pr.sh /usr/local/bin && \
chmod +x /usr/local/bin/git-askpass.sh /usr/local/bin/git-pr.sh && \
chmod +x ./hack/*.sh && \
cp ./hack/*.sh /usr/local/bin && \
/usr/local/bin/runner.sh /bin/sh -ce 'go build -o /usr/local/bin/labels-checker ./robots/cmd/labels-checker' && \
chmod +x /usr/local/bin/labels-checker && \
cd .. && rm -rf ./project-infra
Expand Down