Repository navigation
fix: fail supported PHP image builds below the Oct 2026 security release - #255
Merged
Merged
Conversation
8.2-8.5 images now refuse to build unless PHP_VERSION is at least 8.2.35, 8.3.36, 8.4.27, or 8.5.12. Tags stay at -7 so existing installs pick the patched image up on lando rebuild. EOL images are unchanged.
✅ Deploy Preview for lando-php ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ebe96f6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Supported
devwithlando/phpimages (8.2, 8.3, 8.4, 8.5, apache and fpm) refuse to build unlessPHP_VERSIONis at least the 22 Oct 2026 security release:Those floors are
CVE-2026-109618andCVE-2026-109619. The check is aRUNimmediately after the finalFROM, so a stale base fails the build beforebuild-push-actionpushes.pull: trueis there so BuildKit resolves the official tag from the registry. Tags stay at-7. No plugin release. EOL PHP runtimes (8.1 and older) are not security-patched by this; legacy apt-source maintenance only restores their existing builds.Merging to
mainrebuilds and publishes the production tags. This PR only publishes-edgetags. Do not treat a green EOL job as a fix. After themainbuild, confirm the eight-7Hub digests moved andphp -von amd64 and arm64 meets the floor. Users pick the new image up withlando rebuild, notlando start.Test plan
8.2/8.3/8.4/8.5apacheandfpm-7differ from the 2026-06-24 publishesphp -von both platforms meets the floorNote
Medium Risk
Changes how production multi-arch PHP images are built and published, and enforce minimum PHP versions at build time; mistakes could block releases or ship stale bases.
Overview
Supported PHP 8.2–8.5 FPM/Apache Dockerfiles now fail the build at image time unless
PHP_VERSIONmeets pinnedMIN_PHPfloors (wired frombuild-php-images.yml). EOL bullseye images (7.3–8.0) and the 7.3 example gain Debian archive apt mirrors soaptstill works without dropping signature checks.The PHP image workflow stops using QEMU multi-platform builds on one runner: each tag/arch builds on native runners, pushes by digest, and a new merge job publishes the multi-arch Hub tag. PR/unit CI fixes include macos-15-intel, matrix-backed Lando version for PHP tests, and Leia pinned to 0.6.7 for Node 18 runners.
Reviewed by Cursor Bugbot for commit 77b909e. Bugbot is set up for automated code reviews on this repo. Configure here.
CI maintenance
Pinned the Leia action fallback to the existing lockfile version so its Node 18 runner does not install Node 24-only Leia 2. Restored bullseye archive package sources without disabling package signature verification. The PHP integration matrix now actually selects its stable/edge Lando version.
Local validation: lint and docs build passed; unit command passed (0 passing / 1 pending placeholder). Isolated setup/test/cleanup Leia smoke passed under Node 18.20.8. Full integration and multi-platform image validation are pending the new CI runs.
Native amd64 and arm64 runners now build each image independently and publish the multiarch tag only after both platform digests are uploaded. This avoids QEMU-only legacy dpkg crashes without dropping either architecture. The source rewrite now covers both Debian security mirror hostnames; the PHP 7.3 Node-install fixture repairs its inherited security source before apt runs.