-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding #3444
base: main
Are you sure you want to change the base?
Conversation
fb4bd94
to
6a06f1e
Compare
Rebased to current main, and current state of #3443 . |
6a06f1e
to
8cc45e4
Compare
Rebased |
6e8a1c1
to
dc5a209
Compare
Rebased; after #3513 many changes disappeared :) |
dc5a209
to
27b0ca4
Compare
Rebased, following channel phase #3418 . The channel manager part got much simpler! |
fc2e085
to
f93b0de
Compare
Squashed some commits |
8b3e9b8
to
8526b4a
Compare
Rebased on top of main (had to do magic with the commits...) |
Extended implementation to handle last |
ad7d810
to
db27917
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3444 +/- ##
==========================================
+ Coverage 89.20% 89.67% +0.46%
==========================================
Files 155 155
Lines 119377 124547 +5170
Branches 119377 124547 +5170
==========================================
+ Hits 106496 111687 +5191
+ Misses 10266 10227 -39
- Partials 2615 2633 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…splice_ack messages, but fail afterwards
…nd OutboundV2Channel
db27917
to
3cca201
Compare
Continued implementation: added |
2d7ad1f
to
0c66c80
Compare
This is a next step in the splicing partial implementation, including and depending on the following:
ChannelContext
value fields intoFundingScope
#3592ChannelTransactionParameters
intoFundingScope
#3604Also relevant: #3418
Next step in splicing (#1621): This PR adds the implementation of performing the interactive transaction negotiation for the new post-splice funding transaction, after the
splice_init
&splice_ack
handshake. Only the initiator can currently contribute.The initiator adds the current funding tx as input, plus additional inputs, and the new funding as output plus a change output (if applicable).
After
tx_complete
the flow stops, does not yet follow to the commitment/signature exchange.