Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding #3444

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

optout21
Copy link
Contributor

@optout21 optout21 commented Dec 5, 2024

This is a next step in the splicing partial implementation, including and depending on the following:

Also relevant: #3418

Next step in splicing (#1621): This PR adds the implementation of performing the interactive transaction negotiation for the new post-splice funding transaction, after the splice_init & splice_ack handshake. Only the initiator can currently contribute.
The initiator adds the current funding tx as input, plus additional inputs, and the new funding as output plus a change output (if applicable).
After tx_complete the flow stops, does not yet follow to the commitment/signature exchange.

@optout21
Copy link
Contributor Author

Rebased to current main, and current state of #3443 .

@optout21
Copy link
Contributor Author

optout21 commented Jan 7, 2025

Rebased

@optout21 optout21 force-pushed the splice-dual-tx branch 2 times, most recently from 6e8a1c1 to dc5a209 Compare January 15, 2025 23:22
@optout21
Copy link
Contributor Author

Rebased; after #3513 many changes disappeared :)

@optout21
Copy link
Contributor Author

Rebased, following channel phase #3418 . The channel manager part got much simpler!

@optout21
Copy link
Contributor Author

optout21 commented Mar 5, 2025

Rebased up to 0216d7d #3629 from joostjager/log-attribution-failures Mar 4

Cannot rebase past that, df68774 #3016 somehow breaks my rebaseing...

@optout21
Copy link
Contributor Author

optout21 commented Mar 5, 2025

Squashed some commits

@optout21 optout21 force-pushed the splice-dual-tx branch 4 times, most recently from 8b3e9b8 to 8526b4a Compare March 6, 2025 01:14
@optout21
Copy link
Contributor Author

optout21 commented Mar 6, 2025

Rebased on top of main (had to do magic with the commits...)

@optout21 optout21 changed the title [Draft][Splicing] Partial, perform interactive transaction negotiation for new funding [Early Draft][Splicing] Partial, perform interactive transaction negotiation for new funding Mar 12, 2025
@optout21
Copy link
Contributor Author

Extended implementation to handle last tx_complete, create signature on shared input, and emit FundingTransactionReadyForSigning event.

@optout21 optout21 force-pushed the splice-dual-tx branch 12 times, most recently from ad7d810 to db27917 Compare March 19, 2025 23:27
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 77.64706% with 114 lines in your changes missing coverage. Please review.

Project coverage is 89.67%. Comparing base (c355ea4) to head (db27917).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 69.05% 107 Missing and 1 partial ⚠️
lightning/src/ln/channelmanager.rs 16.66% 5 Missing ⚠️
lightning/src/events/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3444      +/-   ##
==========================================
+ Coverage   89.20%   89.67%   +0.46%     
==========================================
  Files         155      155              
  Lines      119377   124547    +5170     
  Branches   119377   124547    +5170     
==========================================
+ Hits       106496   111687    +5191     
+ Misses      10266    10227      -39     
- Partials     2615     2633      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@optout21
Copy link
Contributor Author

Continued implementation: added funding_transaction_signed methods, tx_complete is handled on both sides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant