This repository was archived by the owner on Aug 28, 2020. It is now read-only.
Adding metrics exporter #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
March 27, 2020 16:45
…moves dependency on ls tracer code
ocelotl
reviewed
Apr 29, 2020
Comment on lines
+63
to
+64
| start = start or 0 | ||
| end = end or 0 |
There was a problem hiding this comment.
What's the idea behind this or 0? Can start or end be False or something similar?
|
|
||
| def shutdown(self) -> None: | ||
| self.tracer.flush() | ||
| """Flush remaining spans""" | ||
| # self.tracer.flush() |
There was a problem hiding this comment.
Should this be commented out?
There was a problem hiding this comment.
Updated the docstring, removed the comment. Currently there's no need to implement anything in the shutdown.
|
|
||
|
|
||
| class LightStepSpanExporter(LightstepSpanExporter): | ||
| """Backwards compatibility wrapper class""" |
There was a problem hiding this comment.
Maybe add a DeprecationWarning here?
|
|
||
| def _generate_guid(): | ||
| """Construct a guid - a random 64 bit integer""" | ||
| return _GUID_RNG.getrandbits(64) - 1 |
There was a problem hiding this comment.
Just a heads up, this could return a negative value (because of the - 1)
There was a problem hiding this comment.
Good catch! Fixed.
Co-Authored-By: Diego Hurtado <[email protected]>
Co-Authored-By: Diego Hurtado <[email protected]>
Co-Authored-By: Diego Hurtado <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of a metrics exporter. As part of the changes here, I'm refactoring the SpanExporter to use protos directly, which removes the dependency on the lightstep-tracer ibrary as well as thrift.
There are a few parts in this change:
Note:
The
collector_pb2.pyandmetrics_pb2.pyfiles are generated, probably not worth reviewing.