fix(cli-config): add parameters for elevation preview urls BM-1407 #3554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our basemaps-config preview URLs for Elevation inserts no longer show anything in Basemaps. Example here.
You can't see the imagery until you add the following parameters to such URLs:
We need to update our cli-config package's
importcommand to add thepipelineandformatparameters automatically.Modifications
packages/cli-config/src/cli/
action.import.tsUpdated the
prepareUrlfunction so that the following key-value pairs are appended to URLs forelevationcategory imagery:Verification
I attempted to introduce a unit test - but abandoned it as I had issues faking the
BasemapsConfigProvidermem parameter required to call theprepareURLfunction.Instead, I ran the
importcommand locally and inspected the URLs produced in the generated markdown:Individual Inserts
thames-2017-2019-dsm-1m
christchurch-urban-2020-2021-0.075m