Skip to content

fix(cli-config): add parameters for elevation preview urls BM-1407 #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(cli-config): add parameters for elevation preview urls BM-1407 #3554

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b71db7
fix(cli-config): add parameters for elevation preview urls
tawera-manaena Nov 3, 2025
e89c468
fix(cli-config): lint
tawera-manaena Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/cli-config/src/cli/action.import.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,10 +410,19 @@ async function prepareUrl(
if (configImagery == null) throw new Error(`Failed to find imagery config from config bundle file. Id: ${id}`);

const center = getPreviewUrl({ imagery: configImagery });

const urls = {
layer: `${PublicUrlBase}?config=${configPath}&i=${center.name}&p=${tileMatrix.identifier}&debug#@${center.location.lat},${center.location.lon},z${center.location.zoom}`,
tag: `${PublicUrlBase}?config=${configPath}&p=${tileMatrix.identifier}&debug#@${center.location.lat},${center.location.lon},z${center.location.zoom}`,
layer: `${PublicUrlBase}@${center.location.lat},${center.location.lon},z${center.location.zoom}?config=${configPath}&i=${center.name}&p=${tileMatrix.identifier}&debug`,
tag: `${PublicUrlBase}@${center.location.lat},${center.location.lon},z${center.location.zoom}?config=${configPath}&p=${tileMatrix.identifier}&debug`,
};

if (configImagery.category?.toLowerCase() === 'elevation') {
Copy link
Member

@blacha blacha Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can rely on the category for determining what pipeline we should use.

Some elevation datasets I believe are not terrain-rgb datasets, there are also other datasets that will need the pipeline parameter. some of these will also have more than one output pipeline that may need to be referenced.

Copy link
Contributor Author

@tawera-manaena tawera-manaena Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, good to know. Let me think on this for a moment.

const elevationParameters = `&pipeline=terrain-rgb&format=png`;

urls.layer += elevationParameters;
urls.tag += elevationParameters;
}

return urls;
}

Expand Down