[HW][Sim] Add SimulationVariableTypeInterface to let hw.inout hold sim value types - #10997
Open
okekayode wants to merge 1 commit into
Open
[HW][Sim] Add SimulationVariableTypeInterface to let hw.inout hold sim value types #10997okekayode wants to merge 1 commit into
hw.inout hold sim value types #10997okekayode wants to merge 1 commit into
Conversation
hw.inout hold sim value types
Member
|
I’m not sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we add a marker interface, SimulationVariableTypeInterface, implemented on
!sim.assoc_array, !sim.queue, and !sim.dstring. InOutType::verify now accepts either a normal HW value type or this interface, sosv.reg/hw.inoutcan hold these simulation-only types.We chose this over widening isHWValueType directly, since it has too many call sites and would let types leak into module ports,
hw.array, etc. This keeps the change scope concise ( ports and aggregates still reject these types).