[Moore] Add missing conversions to open array typesAdd support for OpenUnpackedArrayType constants - #11058
Open
ayush213 wants to merge 2 commits into
Open
[Moore] Add missing conversions to open array typesAdd support for OpenUnpackedArrayType constants#11058ayush213 wants to merge 2 commits into
ayush213 wants to merge 2 commits into
Conversation
Author
|
you checked ?? |
TaoBi22
reviewed
Sep 1, 2026
Contributor
There was a problem hiding this comment.
Thanks for looking at this @ayush213 - looks like you're still running into formatting issues on CI. You should be able to get around those by running clang-format on Expressions.cpp.
It also looks like you have two PR messages in your title - I'm guessing only the second is meant to be there? If you'd be able to add a little bit of information in the PR description in case anyone comes back to look at this, that would also be great!
Otherwise just a couple of comments below
|
|
||
| llvm::SmallVector<mlir::Value> elemVals; | ||
| moore::ConstantOp constOp; | ||
|
|
| } | ||
|
|
||
| // Create open array value | ||
| auto arrType = moore::UnpackedArrayType::get(getContext(), elementType, 0); |
Contributor
There was a problem hiding this comment.
It looks like we already have an OpenUnpackedArrayType in Moore, I would think we probably want to fetch that type instead of just getting an UnpackedArrayType of size 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.