[AXI4] Add concurrent read/write count to subordinate-like ops - #11062
Open
TaoBi22 wants to merge 1 commit into
Open
[AXI4] Add concurrent read/write count to subordinate-like ops#11062TaoBi22 wants to merge 1 commit into
TaoBi22 wants to merge 1 commit into
Conversation
AI-assisted-by: Claude Opus 5
TaoBi22
force-pushed
the
axi4-subordinate-conc
branch
from
August 28, 2026 12:34
b1f166a to
8ab1c03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The outstanding read/write capacity story is slightly muddy at the moment, since the information is now encoded in the types - in the case of subordinate-like ops especially (abstract_subordinate and port_to_channel_structs), it's not semantically clear whether the outstanding counts refer to what the subordinate can handle or what can come down the port.
To clarify this, this PR adds explicit counts to the subordinate-like ops to specify how many concurrent reads/writes they can handle, so the port type can specifically refer to the number of concurrent requests that can actually come down that port. This should make it cleaner to identify potential bottlenecks (and allows us to be stricter with typechecking when we start adding other adaptors etc. since we previously had to account for changes in outstanding read/write counts due to a subordinate setting the type downstream)
AI-assisted-by: Claude Opus 5