[clang-doc] Fix </section> mismatch in the namespace template

[evelez7]

A </section> tag wasn't inside the {{#HasRecords}} Mustache tag, which caused a
mismatch if there weren't any records to render.

[evelez7]

• [clang-doc] <ul> must be nested in <li> #168972
• [clang-doc] Fix </section> mismatch in the namespace template #168966 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-clang-tools-extra

Author: Erick Velez (evelez7)

Changes

A </section> tag wasn't inside the {{#HasRecords}} Mustache tag, which caused a
mismatch if there weren't any records to render.

---

Full diff: https://github.com/llvm/llvm-project/pull/168966.diff

1 Files Affected:

• (modified) clang-tools-extra/clang-doc/assets/namespace-template.mustache (+1-1)

diff --git a/clang-tools-extra/clang-doc/assets/namespace-template.mustache b/clang-tools-extra/clang-doc/assets/namespace-template.mustache
index f4a35cfe4c79a..614023b9f6723 100644
--- a/clang-tools-extra/clang-doc/assets/namespace-template.mustache
+++ b/clang-tools-extra/clang-doc/assets/namespace-template.mustache
@@ -97,8 +97,8 @@
                             </li>
                         {{/Records}}
                         </ul>
-                    {{/HasRecords}}
                     </section>
+                    {{/HasRecords}}
                 </div>
             </div>
         </main>

[evelez7]

If you inspect the HTML, you can see the mismatch in the pre-fix output: https://erickvelez.com/clang-doc-mustache-output/section-mismatch/GlobalNamespace/

Here is the fixed output: https://erickvelez.com/clang-doc-mustache-output/pr168966/GlobalNamespace/

[github-actions]

🐧 Linux x64 Test Results

• 3053 tests passed
• 7 tests skipped

[ilovepi]

LGTM. Took me a minute to realize I needed to check the raw source over using the inspection tool to see the diff.

Can you add a test case?

[ilovepi]

LGTM, modulo a small tweak tot he check line.

[evelez7]

Merge activity

• Nov 21, 7:30 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Nov 21, 7:32 PM UTC: @evelez7 merged this pull request with Graphite.