-
Notifications
You must be signed in to change notification settings - Fork 15.3k
fix tysan test failing on unsupported arches #169066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@llvm/pr-subscribers-clang Author: Matthew Nagy (gbMattN) ChangesFull diff: https://github.com/llvm/llvm-project/pull/169066.diff 1 Files Affected:
diff --git a/clang/test/CodeGen/sanitize-type-outlined.cpp b/clang/test/CodeGen/sanitize-type-outlined.cpp
index 64e0882aa1e1a..67e2f49e53d34 100644
--- a/clang/test/CodeGen/sanitize-type-outlined.cpp
+++ b/clang/test/CodeGen/sanitize-type-outlined.cpp
@@ -1,4 +1,4 @@
-// UNSUPPORTED: target={{.*}}-windows-{{.*}}
+// REQUIRES: target=x86_64-linux-gnu
// RUN: %clang -S -fsanitize=type -emit-llvm -o - -fsanitize=type %s \
// RUN: -fno-sanitize-type-outline-instrumentation \
|
🐧 Linux x64 Test Results
Failed Tests(click on a test name to see its output) ORC-x86_64-linuxORC-x86_64-linux.TestCases/Linux/x86-64/lljit-ehframe.cpp (Likely Already Failing)This test is already failing at the base commit.ORC-x86_64-linux.TestCases/Linux/x86-64/lljit-initialize-deinitialize.ll (Likely Already Failing)This test is already failing at the base commit.If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
|
Those ORC tests aren't touched by me, so I'm considering this passing and fixing the problem |
| @@ -1,4 +1,4 @@ | |||
| // UNSUPPORTED: target={{.*}}-windows-{{.*}} | |||
| // REQUIRES: target=x86_64-linux-gnu | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This effectively disables the test because 'target' is not one of the features recognized by clang tests.
You can verify that by running llvm-lit manually.
The triple should be specified in RUN lines instead, no REQUIRES is necessary.
No description provided.