Skip to content

Conversation

@fmayer
Copy link
Contributor

@fmayer fmayer commented Dec 6, 2025

This happened to work because we were missing both a namespace close and
open and things happened to be included in the correct order.

Created using spr 1.3.7
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:dataflow Clang Dataflow Analysis framework - https://clang.llvm.org/docs/DataFlowAnalysisIntro.html labels Dec 6, 2025
@fmayer fmayer requested a review from jvoung December 6, 2025 00:34
@llvmbot
Copy link
Member

llvmbot commented Dec 6, 2025

@llvm/pr-subscribers-clang

Author: Florian Mayer (fmayer)

Changes

This happened to work because we were missing both a namespace close and
open and things happened to be included in the correct order.


Full diff: https://github.com/llvm/llvm-project/pull/170954.diff

1 Files Affected:

  • (modified) clang/unittests/Analysis/FlowSensitive/MockHeaders.cpp (+4)
diff --git a/clang/unittests/Analysis/FlowSensitive/MockHeaders.cpp b/clang/unittests/Analysis/FlowSensitive/MockHeaders.cpp
index 76c7310e16a4f..8ea2015da08df 100644
--- a/clang/unittests/Analysis/FlowSensitive/MockHeaders.cpp
+++ b/clang/unittests/Analysis/FlowSensitive/MockHeaders.cpp
@@ -1358,6 +1358,8 @@ bool operator!=(const Status &lhs, const Status &rhs);
 Status OkStatus();
 Status InvalidArgumentError(const char *);
 
+}  // namespace absl
+
 #endif // STATUS_H
 )cc";
 
@@ -1370,6 +1372,8 @@ constexpr const char StatusOrDefsHeader[] = R"cc(
 #include "std_type_traits.h"
 #include "std_utility.h"
 
+namespace absl {
+
 template <typename T> struct StatusOr;
 
 namespace internal_statusor {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:dataflow Clang Dataflow Analysis framework - https://clang.llvm.org/docs/DataFlowAnalysisIntro.html clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants