[libc] Add `dlfcn.h` placeholder #97501

izaakschroeder · 2024-07-03T00:56:05Z

Adds dlopen and friends. This is needed as part of the effort to compile libunwind + libc without baremetal mode. This is part of #97191. This should still be spec compliant, since dlopen always returns NULL and dlerror always returns an error message.

If dlopen() fails for any reason, it returns NULL.

The function dlclose() returns 0 on success, and nonzero on error.

Since the value of the symbol could actually be NULL (so that a NULL return from dlsym() need not indicate an error), the correct way to test for an error is to call dlerror() to clear any old error conditions, then call dlsym(), and then call dlerror() again, saving its return value into a variable, and check whether this saved value is not NULL.

See:

https://linux.die.net/man/3/dlopen

llvmbot · 2024-07-03T00:56:33Z

@llvm/pr-subscribers-libc

Author: Izaak Schroeder (izaakschroeder)

Changes

Adds dlopen and friends. This is needed to compile libunwind + libc without baremetal mode. This is part of #97191

Full diff: https://github.com/llvm/llvm-project/pull/97501.diff

19 Files Affected:

(modified) libc/config/linux/aarch64/entrypoints.txt (+6)
(modified) libc/config/linux/aarch64/headers.txt (+1)
(modified) libc/config/linux/x86_64/entrypoints.txt (+6)
(modified) libc/config/linux/x86_64/headers.txt (+1)
(modified) libc/include/CMakeLists.txt (+9)
(added) libc/include/dlfcn.h.def (+17)
(modified) libc/include/llvm-libc-macros/CMakeLists.txt (+6)
(added) libc/include/llvm-libc-macros/dlfcn-macros.h (+23)
(modified) libc/spec/posix.td (+35)
(modified) libc/src/CMakeLists.txt (+1)
(added) libc/src/dlfcn/CMakeLists.txt (+43)
(added) libc/src/dlfcn/dlclose.cpp (+17)
(added) libc/src/dlfcn/dlclose.h (+18)
(added) libc/src/dlfcn/dlerror.cpp (+19)
(added) libc/src/dlfcn/dlerror.h (+18)
(added) libc/src/dlfcn/dlopen.cpp (+17)
(added) libc/src/dlfcn/dlopen.h (+18)
(added) libc/src/dlfcn/dlsym.cpp (+17)
(added) libc/src/dlfcn/dlsym.h (+18)

diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 940df63e3912b..70c588622ec6b 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -17,6 +17,12 @@ set(TARGET_LIBC_ENTRYPOINTS
     libc.src.ctype.tolower
     libc.src.ctype.toupper
 
+    # dlfcn.h entrypoints
+    libc.src.dlfcn.dlopen
+    libc.src.dlfcn.dlsym
+    libc.src.dlfcn.dlclose
+    libc.src.dlfcn.dlerror
+
     # errno.h entrypoints
     libc.src.errno.errno
 
diff --git a/libc/config/linux/aarch64/headers.txt b/libc/config/linux/aarch64/headers.txt
index 7d25877cefcc8..8f898f0150905 100644
--- a/libc/config/linux/aarch64/headers.txt
+++ b/libc/config/linux/aarch64/headers.txt
@@ -1,6 +1,7 @@
 set(TARGET_PUBLIC_HEADERS
     libc.include.assert
     libc.include.ctype
+    libc.include.dlfcn
     libc.include.errno
     libc.include.features
     libc.include.fenv
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 09f04fb31dfd8..ba60475809853 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -17,6 +17,12 @@ set(TARGET_LIBC_ENTRYPOINTS
     libc.src.ctype.tolower
     libc.src.ctype.toupper
 
+    # dlfcn.h entrypoints
+    libc.src.dlfcn.dlopen
+    libc.src.dlfcn.dlsym
+    libc.src.dlfcn.dlclose
+    libc.src.dlfcn.dlerror
+
     # errno.h entrypoints
     libc.src.errno.errno
 
diff --git a/libc/config/linux/x86_64/headers.txt b/libc/config/linux/x86_64/headers.txt
index 44d640b75e2bf..df276894246c4 100644
--- a/libc/config/linux/x86_64/headers.txt
+++ b/libc/config/linux/x86_64/headers.txt
@@ -2,6 +2,7 @@ set(TARGET_PUBLIC_HEADERS
     libc.include.assert
     libc.include.ctype
     libc.include.dirent
+    libc.include.dlfcn
     libc.include.errno
     libc.include.fcntl
     libc.include.features
diff --git a/libc/include/CMakeLists.txt b/libc/include/CMakeLists.txt
index 3ab7817d8568b..f8ef35078a8c4 100644
--- a/libc/include/CMakeLists.txt
+++ b/libc/include/CMakeLists.txt
@@ -51,6 +51,15 @@ add_gen_header(
     .llvm_libc_common_h
 )
 
+add_gen_header(
+  dlfcn
+  DEF_FILE dlfcn.h.def
+  GEN_HDR dlfcn.h
+  DEPENDS
+    .llvm-libc-macros.dlfcn_macros
+    .llvm_libc_common_h
+)
+
 add_gen_header(
   features
   DEF_FILE features.h.def
diff --git a/libc/include/dlfcn.h.def b/libc/include/dlfcn.h.def
new file mode 100644
index 0000000000000..31395871c6b97
--- /dev/null
+++ b/libc/include/dlfcn.h.def
@@ -0,0 +1,17 @@
+//===-- C standard library header dlfcn.h ---------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_DLFCN_H
+#define LLVM_LIBC_DLFCN_H
+
+#include "__llvm-libc-common.h"
+#include "llvm-libc-macros/dlfcn-macros.h"
+
+%%public_api()
+
+#endif // LLVM_LIBC_DLFCN_H
diff --git a/libc/include/llvm-libc-macros/CMakeLists.txt b/libc/include/llvm-libc-macros/CMakeLists.txt
index f6af11abd4dd7..5bf573e4e98df 100644
--- a/libc/include/llvm-libc-macros/CMakeLists.txt
+++ b/libc/include/llvm-libc-macros/CMakeLists.txt
@@ -277,3 +277,9 @@ add_macro_header(
   HDR
     stdckdint-macros.h
 )
+
+add_macro_header(
+  dlfcn_macros
+  HDR
+    dlfcn-macros.h
+)
\ No newline at end of file
diff --git a/libc/include/llvm-libc-macros/dlfcn-macros.h b/libc/include/llvm-libc-macros/dlfcn-macros.h
new file mode 100644
index 0000000000000..dcd202b9ab435
--- /dev/null
+++ b/libc/include/llvm-libc-macros/dlfcn-macros.h
@@ -0,0 +1,23 @@
+//===-- Definition of macros from dlfcn.h ---------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_MACROS_DLFCN_MACROS_H
+#define LLVM_LIBC_MACROS_DLFCN_MACROS_H
+
+#define RTLD_LAZY 0x00001
+#define RTLD_NOW 0x00002
+#define RTLD_GLOBAL 0x00100
+#define RTLD_LOCAL 0
+
+// Non-standard stuff here
+#define RTLD_BINDING_MASK 0x3
+#define RTLD_NOLOAD 0x00004
+#define RTLD_DEEPBIND 0x00008
+#define RTLD_NODELETE 0x01000
+
+#endif // LLVM_LIBC_MACROS_DLFCN_MACROS_H
diff --git a/libc/spec/posix.td b/libc/spec/posix.td
index d14047548e104..1878b1ee2ae41 100644
--- a/libc/spec/posix.td
+++ b/libc/spec/posix.td
@@ -222,6 +222,40 @@ def POSIX : StandardSpec<"POSIX"> {
       []  // Functions
   >;
 
+  HeaderSpec DlFcn = HeaderSpec<
+    "dlfcn.h",
+    [
+      Macro<"RTLD_LAZY">,
+      Macro<"RTLD_NOW">,
+      Macro<"RTLD_GLOBAL">,
+      Macro<"RTLD_LOCAL">,
+    ],
+    [],  // Types
+    [], // Enumerations
+    [
+      FunctionSpec<
+          "dlclose",
+          RetValSpec<IntType>,
+          [ArgSpec<VoidPtr>]
+      >,
+      FunctionSpec<
+          "dlerror",
+          RetValSpec<CharPtr>,
+          []
+      >,
+      FunctionSpec<
+          "dlopen",
+          RetValSpec<VoidPtr>,
+          [ArgSpec<ConstCharPtr>, ArgSpec<IntType>]
+      >,
+      FunctionSpec<
+          "dlsym",
+          RetValSpec<VoidPtr>,
+          [ArgSpec<VoidRestrictedPtr>, ArgSpec<ConstCharRestrictedPtr>]
+      >,
+    ]
+  >;
+
   HeaderSpec FCntl = HeaderSpec<
     "fcntl.h",
     [], // Macros
@@ -1690,6 +1724,7 @@ def POSIX : StandardSpec<"POSIX"> {
     ArpaInet,
     CType,
     Dirent,
+    DlFcn,
     Errno,
     FCntl,
     PThread,
diff --git a/libc/src/CMakeLists.txt b/libc/src/CMakeLists.txt
index 09b16be1e2d42..f011fe25226e5 100644
--- a/libc/src/CMakeLists.txt
+++ b/libc/src/CMakeLists.txt
@@ -11,6 +11,7 @@ add_subdirectory(stdio)
 add_subdirectory(stdlib)
 add_subdirectory(string)
 add_subdirectory(wchar)
+add_subdirectory(dlfcn)
 
 if(${LIBC_TARGET_OS} STREQUAL "linux")
   add_subdirectory(dirent)
diff --git a/libc/src/dlfcn/CMakeLists.txt b/libc/src/dlfcn/CMakeLists.txt
new file mode 100644
index 0000000000000..5534f2dfb8853
--- /dev/null
+++ b/libc/src/dlfcn/CMakeLists.txt
@@ -0,0 +1,43 @@
+add_entrypoint_object(
+  dlclose
+  SRCS
+    dlclose.cpp
+  HDRS
+    dlclose.h
+  DEPENDS
+    libc.include.dlfcn
+    libc.src.errno.errno
+)
+
+add_entrypoint_object(
+  dlerror
+  SRCS
+    dlerror.cpp
+  HDRS
+    dlerror.h
+  DEPENDS
+    libc.include.dlfcn
+    libc.src.errno.errno
+)
+
+add_entrypoint_object(
+  dlopen
+  SRCS
+    dlopen.cpp
+  HDRS
+    dlopen.h
+  DEPENDS
+    libc.include.dlfcn
+    libc.src.errno.errno
+)
+
+add_entrypoint_object(
+  dlsym
+  SRCS
+    dlsym.cpp
+  HDRS
+    dlsym.h
+  DEPENDS
+    libc.include.dlfcn
+    libc.src.errno.errno
+)
diff --git a/libc/src/dlfcn/dlclose.cpp b/libc/src/dlfcn/dlclose.cpp
new file mode 100644
index 0000000000000..6dc1892120ddd
--- /dev/null
+++ b/libc/src/dlfcn/dlclose.cpp
@@ -0,0 +1,17 @@
+//===-- Implementation of dlclose -----------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "dlclose.h"
+
+#include "src/__support/common.h"
+
+namespace LIBC_NAMESPACE {
+
+LLVM_LIBC_FUNCTION(int, dlclose, (void *)) { return -1; }
+
+} // namespace LIBC_NAMESPACE
diff --git a/libc/src/dlfcn/dlclose.h b/libc/src/dlfcn/dlclose.h
new file mode 100644
index 0000000000000..27c0207d726e4
--- /dev/null
+++ b/libc/src/dlfcn/dlclose.h
@@ -0,0 +1,18 @@
+//===-- Implementation header of dlclose ------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_DLFCN_DLCLOSE_H
+#define LLVM_LIBC_SRC_DLFCN_DLCLOSE_H
+
+namespace LIBC_NAMESPACE {
+
+int dlclose(void *);
+
+} // namespace LIBC_NAMESPACE
+
+#endif // LLVM_LIBC_SRC_DLFCN_DLCLOSE_H
diff --git a/libc/src/dlfcn/dlerror.cpp b/libc/src/dlfcn/dlerror.cpp
new file mode 100644
index 0000000000000..8c3611d9c639e
--- /dev/null
+++ b/libc/src/dlfcn/dlerror.cpp
@@ -0,0 +1,19 @@
+//===-- Implementation of delerror ----------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "dlerror.h"
+
+#include "src/__support/common.h"
+
+namespace LIBC_NAMESPACE {
+
+LLVM_LIBC_FUNCTION(char *, dlerror, ()) {
+  return const_cast<char *>("unsupported");
+}
+
+} // namespace LIBC_NAMESPACE
diff --git a/libc/src/dlfcn/dlerror.h b/libc/src/dlfcn/dlerror.h
new file mode 100644
index 0000000000000..966496016d3eb
--- /dev/null
+++ b/libc/src/dlfcn/dlerror.h
@@ -0,0 +1,18 @@
+//===-- Implementation header of dlerror ------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_DLFCN_DLERROR_H
+#define LLVM_LIBC_SRC_DLFCN_DLERROR_H
+
+namespace LIBC_NAMESPACE {
+
+char *dlerror();
+
+} // namespace LIBC_NAMESPACE
+
+#endif // LLVM_LIBC_SRC_DLFCN_DLERROR_H
diff --git a/libc/src/dlfcn/dlopen.cpp b/libc/src/dlfcn/dlopen.cpp
new file mode 100644
index 0000000000000..835d981e19237
--- /dev/null
+++ b/libc/src/dlfcn/dlopen.cpp
@@ -0,0 +1,17 @@
+//===-- Implementation of dlopen -----------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "dlopen.h"
+
+#include "src/__support/common.h"
+
+namespace LIBC_NAMESPACE {
+
+LLVM_LIBC_FUNCTION(void *, dlopen, (const char *, int)) { return nullptr; }
+
+} // namespace LIBC_NAMESPACE
diff --git a/libc/src/dlfcn/dlopen.h b/libc/src/dlfcn/dlopen.h
new file mode 100644
index 0000000000000..4565953efd494
--- /dev/null
+++ b/libc/src/dlfcn/dlopen.h
@@ -0,0 +1,18 @@
+//===-- Implementation header of dlopen -------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_DLFCN_DLOPEN_H
+#define LLVM_LIBC_SRC_DLFCN_DLOPEN_H
+
+namespace LIBC_NAMESPACE {
+
+void *dlopen(const char *, int);
+
+} // namespace LIBC_NAMESPACE
+
+#endif // LLVM_LIBC_SRC_DLFCN_DLOPEN_H
diff --git a/libc/src/dlfcn/dlsym.cpp b/libc/src/dlfcn/dlsym.cpp
new file mode 100644
index 0000000000000..98d678caece90
--- /dev/null
+++ b/libc/src/dlfcn/dlsym.cpp
@@ -0,0 +1,17 @@
+//===-- Implementation of dlsym ------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "dlsym.h"
+
+#include "src/__support/common.h"
+
+namespace LIBC_NAMESPACE {
+
+LLVM_LIBC_FUNCTION(void *, dlsym, (void *, const char *)) { return nullptr; }
+
+} // namespace LIBC_NAMESPACE
diff --git a/libc/src/dlfcn/dlsym.h b/libc/src/dlfcn/dlsym.h
new file mode 100644
index 0000000000000..8157ac3e3fd4c
--- /dev/null
+++ b/libc/src/dlfcn/dlsym.h
@@ -0,0 +1,18 @@
+//===-- Implementation header of dlsym --------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_DLFCN_DLSYM_H
+#define LLVM_LIBC_SRC_DLFCN_DLSYM_H
+
+namespace LIBC_NAMESPACE {
+
+void *dlsym(void *, const char *);
+
+} // namespace LIBC_NAMESPACE
+
+#endif // LLVM_LIBC_SRC_DLFCN_DLSYM_H

izaakschroeder · 2024-07-03T00:57:20Z

/cc @michaelrj-google @jhuber6

izaakschroeder · 2024-07-03T00:57:56Z

/cc @SchrodingerZhu

libc/config/linux/aarch64/entrypoints.txt

libc/config/linux/x86_64/entrypoints.txt

libc/src/dlfcn/CMakeLists.txt

overmighty · 2024-07-06T10:03:43Z

libc/src/dlfcn/dlerror.cpp

+LLVM_LIBC_FUNCTION(char *, dlerror, ()) {
+  return const_cast<char *>("unsupported");


Not sure if that const_cast is fine. Despite the non-const char * return type, POSIX does state that "The application shall not modify the string returned": https://pubs.opengroup.org/onlinepubs/9699919799/functions/dlerror.html.

I had the same thoughts… it looks like the caller is not supposed to touch this pointer so this seemed safe to me? If someone knows better lmk and I will change it.

overmighty · 2024-07-06T19:41:25Z

There weren't any merge conflicts, were there? If you amend and force-push to have only 1 commit on the pull request, then you shouldn't do that. See https://llvm.org/docs/GitHub.html#updating-pull-requests.

Even if there are merge conflicts, you should rebase your existing commits instead of resetting your branch and creating a single new commit.

izaakschroeder · 2024-07-06T20:00:07Z

There weren't any merge conflicts, were there? If you amend and force-push to have only 1 commit on the pull request, then you shouldn't do that. See https://llvm.org/docs/GitHub.html#updating-pull-requests.

Even if there are merge conflicts, you should rebase your existing commits instead of resetting your branch and creating a single new commit.

Ok I can do that no problem 😀 I do like the idea of tracking review changes... though my habit has normally been to clean everything up before merging and I guess I had figured we were pretty close. I guess also squash and merge takes care of most of this... I fast-forward most of my things which is probably also where this habit of manual cleanup comes from. Thanks for the heads up!

SchrodingerZhu

LGTM. But I would like to put some TODOs inside the comment. Also, please add a comment about the dlerror return in the Undefined Behavior document section: https://github.com/llvm/llvm-project/blob/main/libc/docs/dev/undefined_behavior.rst

lntue · 2024-07-06T22:21:22Z

LGTM. But I would like to put some TODOs inside the comment. Also, please add a comment about the dlerror return in the Undefined Behavior document section: https://github.com/llvm/llvm-project/blob/main/libc/docs/dev/undefined_behavior.rst

+1 on adding TODO. It would be even better if you don't mind creating github issues for those TODOs and link to them in the comments.

SchrodingerZhu

LGTM

izaakschroeder changed the title ~~[libc]: add dlfcn.h placeholder~~ [libc] Add dlfcn.h placeholder Jul 3, 2024

llvmbot added the libc label Jul 3, 2024

izaakschroeder force-pushed the libc-dlfcn branch from 85ef9d7 to eb52173 Compare July 3, 2024 00:56

This was referenced Jul 3, 2024

[libc] Add link.h and elf.h placeholder #97504

Closed

[libc] build clang #97191

Open

izaakschroeder force-pushed the libc-dlfcn branch 2 times, most recently from e094dfb to 02a0b3e Compare July 6, 2024 05:07

overmighty reviewed Jul 6, 2024

View reviewed changes

[libc] Add dlfcn.h placeholder

33012d8

izaakschroeder force-pushed the libc-dlfcn branch from 1a1c0c2 to 33012d8 Compare July 6, 2024 19:00

lntue requested review from SchrodingerZhu and overmighty July 6, 2024 22:01

SchrodingerZhu reviewed Jul 6, 2024

View reviewed changes

This was referenced Jul 6, 2024

[libc] Implement dlfcn.dlclose #97917

Open

[libc] Implement dlfcn.dlerror #97918

Open

[libc] Implement dlfcn.dlopen #97919

Open

[libc] Implement dlfcn.dlsym #97920

Open

izaakschroeder added 2 commits July 6, 2024 15:33

fixup! add TODO links

66f6e5a

fixup! Add undefined behavior notes

3d767a0

SchrodingerZhu approved these changes Jul 6, 2024

View reviewed changes

SchrodingerZhu merged commit b151c7e into llvm:main Jul 6, 2024
7 checks passed

izaakschroeder deleted the libc-dlfcn branch July 6, 2024 23:41

RossComputerGuy mentioned this pull request Dec 27, 2024

[libc] add dl_iterate_phdr and dladdr #121179

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libc] Add `dlfcn.h` placeholder #97501

[libc] Add `dlfcn.h` placeholder #97501

izaakschroeder commented Jul 3, 2024 •

edited

Loading

llvmbot commented Jul 3, 2024

izaakschroeder commented Jul 3, 2024

izaakschroeder commented Jul 3, 2024

overmighty Jul 6, 2024

izaakschroeder Jul 6, 2024

overmighty commented Jul 6, 2024

izaakschroeder commented Jul 6, 2024 •

edited

Loading

SchrodingerZhu left a comment •

edited

Loading

lntue commented Jul 6, 2024

SchrodingerZhu left a comment

		LLVM_LIBC_FUNCTION(char *, dlerror, ()) {
		return const_cast<char *>("unsupported");

[libc] Add dlfcn.h placeholder #97501

[libc] Add dlfcn.h placeholder #97501

Conversation

izaakschroeder commented Jul 3, 2024 • edited Loading

llvmbot commented Jul 3, 2024

izaakschroeder commented Jul 3, 2024

izaakschroeder commented Jul 3, 2024

overmighty Jul 6, 2024

Choose a reason for hiding this comment

izaakschroeder Jul 6, 2024

Choose a reason for hiding this comment

overmighty commented Jul 6, 2024

izaakschroeder commented Jul 6, 2024 • edited Loading

SchrodingerZhu left a comment • edited Loading

Choose a reason for hiding this comment

lntue commented Jul 6, 2024

SchrodingerZhu left a comment

Choose a reason for hiding this comment

[libc] Add `dlfcn.h` placeholder #97501

[libc] Add `dlfcn.h` placeholder #97501

izaakschroeder commented Jul 3, 2024 •

edited

Loading

izaakschroeder commented Jul 6, 2024 •

edited

Loading

SchrodingerZhu left a comment •

edited

Loading