fix(toolkit): language tag check should be case insensitive #7164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/tame-snails-fold.md | 📈 +588 Bytes |
| packages/toolkit/language-kit/src/utility.ts | 📈 +78 Bytes |
| packages/translate/src/prompts.ts | 📈 +34 Bytes |
simeng-li
approved these changes
Mar 24, 2025
gao-sun
approved these changes
Mar 24, 2025
Co-authored-by: Gao Sun <[email protected]>
charIeszhao
deleted the
charles-language-tag-check-should-be-case-insensitive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Language tag check should be case insensitive. Our language tags in
phrasesandphrases-experienceare in lowercase, such aspt-brandzh-cn. However, the language tag is case sensitive in toolkit, e.g.,pt-BRandzh-CN.This causes a bug that some language tags that contain regional variation suffixes will not be picked up by the translate CLI, and thus lots of phrases end up untranslated.
Testing
Locally
Checklist
.changeset