Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolkit): language tag check should be case insensitive #7164

Merged
merged 4 commits into from
Mar 25, 2025
+16 −5
Merged

fix(toolkit): language tag check should be case insensitive #7164

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bfb8c08
fix(toolkit): language tag check should be case insensitive
charIeszhao Mar 20, 2025
8f00c45
chore: add changeset
charIeszhao Mar 20, 2025
86814d3
fix(translate): fix target language variable in prompt
charIeszhao Mar 24, 2025
5c5da7b
refactor: update changeset
charIeszhao Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: update changeset 
Co-authored-by: Gao Sun <gao@silverhand.io>
@charIeszhao @gao-sun
charIeszhao and gao-sun authored Mar 25, 2025
commit 5c5da7b3543ddc390b480fa30ca524b172537628
2 changes: 1 addition & 1 deletion .changeset/tame-snails-fold.md
View file
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
"@logto/translate": patch
---

utility method `isLanguageTag` should be case insensitive.
make method `isLanguageTag` case-insensitive

The language tags should be case insensitive. In `phrases` and `phrases-experience` packages, the language tags are all in lowercase. However, in the language kit, the language tags are in mixed cases, such as `pt-BR` and `zh-CN`.

Unchanged files with check annotations Beta

View file
Dockerfile
###### [STAGE] Build ######
FROM node:20-alpine as builder

Check warning on line 2 in Dockerfile

GitHub Actions / main-dockerize

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
WORKDIR /etc/logto
ENV CI=true
RUN rm -rf .scripts pnpm-*.yaml packages/cloud
###### [STAGE] Seal ######
FROM node:20-alpine as app

Check warning on line 41 in Dockerfile

GitHub Actions / main-dockerize

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
WORKDIR /etc/logto
COPY --from=builder /etc/logto .
RUN mkdir -p /etc/logto/packages/cli/alteration-scripts && chmod g+w /etc/logto/packages/cli/alteration-scripts