[qemu] Enable the tpm_tx_rx test to run with qemu #28542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engdoreis
requested review from
AlexJones0,
cfrantz and
jwnrt
and removed request for
a team
AlexJones0
reviewed
Oct 22, 2025
| // Could potentially be implemented by sending an empty packet that | ||
| // holds the CS and another which deasserts when dropped. | ||
| Err(TransportError::UnsupportedOperation.into()) | ||
| Ok(AssertChipSelect::new(self)) |
There was a problem hiding this comment.
Does this change make sense? It will allow host code that calls spi.assert_cs() to compile, but this isn't actually sending packets with the CS signals to QEMU.
There was a problem hiding this comment.
In my interpretation, CS doesn't make sense for QEMU because it's now a bus implemented with pins, so I think that the qemu transport should just fake it.
There was a problem hiding this comment.
I added a warning for now. As we disscussed, this would need a larger refactor of the way the ChipSelect is handled.
Signed-off-by: Douglas Reis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.