fix(rsg): repair the release build broken by the findNode global check - #1099
Merged
Conversation
…al check `sgRoot.mGlobal !== this` fails to compile: mGlobal is a `Global`, which TypeScript sees as having no overlap with the polymorphic `this`, so `tsc`/ts-loader raise TS2367 and the brs-scenegraph build fails. Widen to RoSGNode before comparing, the same way the earlier global-node check did. Only a clean build surfaces it — an incremental rebuild reuses the cached module and reports success, which is how it reached master. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master is red
sgRoot.mGlobal !== this(introduced in #1096) does not compile:brs-scenegraph's webpack/ts-loader andtscboth reject it, sonpm run buildfails.Fix
Widen to
RoSGNodebefore comparing — the same thing the earlier global-node check in #1094 did for exactly this reason. Behavior is unchanged.Why it got through
Only a clean build surfaces it. An incremental rebuild reuses the cached module and reports success, and the test suite then runs against the previously-built bundles. Verified:
npm run clean && npm run buildreproduces it on master, and passes with this change (0 TypeScript errors, both bundles emitted).Full suite green (2240), lint and prettier clean.
🤖 Generated with Claude Code