Skip to content

fix(rsg): repair the release build broken by the findNode global check #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lvcabral merged 1 commit into from
Jul 28, 2026
Merged

fix(rsg): repair the release build broken by the findNode global check #1099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/extensions/scenegraph/components/RoSGNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1805,7 +1805,10 @@ export abstract class RoSGNode extends BrsComponent implements BrsValue, ISGNode
// node appended to m.global via m.global.findNode(). Skipping the self-search keeps
// that boundary — every other node's subtree is part of its ancestor's anyway, so
// searching it first is only a shortcut.
const searchSelf: boolean = sgRoot.mGlobal !== this;
// Widened to RoSGNode so the comparison type-checks: `sgRoot.mGlobal` is a `Global`,
// which TypeScript sees as having no overlap with the polymorphic `this`.
const globalNode: RoSGNode = sgRoot.mGlobal;
const searchSelf: boolean = globalNode !== this;
let node: RoSGNode | BrsInvalid = searchSelf ? this.findNodeById(this, id) : BrsInvalid.Instance;
if (node instanceof BrsInvalid) {
// if not found, search from root
Expand Down