Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log HTTP/2 ping from server #11664

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Do not log HTTP/2 ping from server #11664

merged 2 commits into from
Mar 25, 2025

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Mar 19, 2025

Also add test case that the ping is properly responded to (netty does this for us).

Fixes #10376

Also add test case that the ping is properly responded to (netty does this for us).

Fixes #10376
@yawkat yawkat added the type: bug Something isn't working label Mar 19, 2025
@yawkat yawkat added this to the 4.8.8 milestone Mar 19, 2025
@yawkat yawkat requested a review from sdelamo March 19, 2025 09:31
Copy link
Contributor

@kevin-wise kevin-wise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@yawkat yawkat merged commit fc56fb1 into 4.8.x Mar 25, 2025
22 checks passed
@yawkat yawkat deleted the client-ping-response branch March 25, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants