[CUDA] [fix] enable max_depth in cuda tree learner (fix #6969) #6994
Conversation
shiyu1994
requested review from
StrikerRUS,
borchero,
guolinke,
jameslamb and
jmoralez
as code owners
|
Hey there, it would be great to have this merged into master. Any ETA on this? |
|
@lorenzolucchese thanks for your interest in LightGBM. Please don't post "any update on this?" types of comments here. They just generate stress and notifications for the volunteers here without helping to move the project forward. You're always welcome to comment if you have new information to provide or want to offer to help, but otherwise please just click "subscribe" on issues/PRs you're interested in, and GitHub will notify you when there's new activity on them. |
There was a problem hiding this comment.
@shiyu1994 can you please review the proposed changes in #7017 and merge them in here if you agree?
And then I left some comments there... we should be adding tests that confirm max_depth is working as expected. That'd give us more confidence in these changes AND help with all variants of LightGBM (not just CUDA).
4 participants
This is the enable max depth constraint of leaves in cuda tree learner. Fix #6969.