-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[CUDA] [fix] enable max_depth in cuda tree learner - fix build #7017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: fix-6969
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree company="GSA Capital" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I'll let @shiyu1994 comment on the C++ changes.
Please see my suggestions on the testing changes. I do agree that #6994 needs at least one test like this, but I'd change the way it's written.
If you don't have the time or interest in addressing that feedback, please let me know and I'll just push the changes directly in a separate PR.
@shiyu1994 do you think you could take a quick look? I think this should be good to merge. Thank you! |
Small changes to fix the cuda build for the PR #6994. I also added a test checking the
max_depth
parameter is indeed enforced to the python package tests.I tested this locally as follows:
1. Clone, modify and install
lightgbm
locallyMy system:
2. Test that
max_depth
is indeed enforced (cf. Issue #6969)Reproducible example