-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[ci] move js and json linter biome
to pre-commit
#7059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
# pixi environments | ||
.pixi | ||
|
||
# mypy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"enabled": true, | ||
"useEditorconfig": true | ||
"useEditorconfig": true, | ||
"lineWidth": 120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That property has been deprecated and isn't part of the editor config anymore
editorconfig/editorconfig#387
@@ -1,21 +1,21 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New config is a result of the following v2 release: https://biomejs.dev/guides/upgrade-to-biome-v2/
{ | ||
"files": { | ||
"ignore": [".mypy_cache/", ".pixi/"] | ||
"root": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's needed because pre-commit creates another one root config on the fly.
biome ci.................................................................Failed
- hook id: biome-ci
- exit code: 1
configuration ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
✖ Found a nested root configuration, but there's already a root configuration.
ℹ The other configuration was found in .
ℹ Use the migration command from the root of the project to update the configuration.
$ biome migrate --write
configuration ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
✖ Biome exited because the configuration resulted in errors. Please fix them.
https://pre-commit.com/#node
I decided to check that and made the following actions config:
Works fine on Windows, macOS and Ubuntu: https://github.com/microsoft/LightGBM/actions/runs/18497387840