-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[ci] move js and json linter biome
to pre-commit
#7059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 50 commits
d495261
bc762c1
6d6e1d9
a2f5bfc
b254d61
3a43bf7
c429ac1
bf4d6c1
8a10ab2
f7981aa
3710446
327b9cb
8392b8e
2168274
ed32a87
8f02ff3
3a190bd
f0c1a2b
7b91024
6475a28
9b5b8d7
9c252ec
89201c8
dad2ffc
61a9fab
163b9b6
0b558dd
99d61c5
83b8e86
77858ec
5f6b1fc
3b63b1c
d8747c9
a30a74c
64beec8
7cdd772
c8cd3a4
dc30571
122558e
d21be41
8c3f516
d222ec0
b4ff403
48883fe
ae5ae19
336bb0a
f49812c
aaa7d8f
4d8e237
dadad7c
baa31e2
7e7d0d9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,17 +62,22 @@ repos: | |
- sphinx>=8.1.3 | ||
- sphinx_rtd_theme>=3.0.1 | ||
- repo: https://github.com/astral-sh/ruff-pre-commit | ||
# Ruff version. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. totally agree with removing these comments, thank you for doing that. |
||
rev: v0.14.0 | ||
hooks: | ||
# Run the linter. | ||
- id: ruff-check | ||
args: ["--config", "python-package/pyproject.toml"] | ||
types_or: [python, jupyter] | ||
# Run the formatter. | ||
- id: ruff-format | ||
args: ["--config", "python-package/pyproject.toml"] | ||
types_or: [python, jupyter] | ||
- repo: https://github.com/biomejs/pre-commit | ||
rev: v2.2.5 | ||
hooks: | ||
- id: biome-ci | ||
args: | ||
- --config-path=./biome.json | ||
- --diagnostic-level=info | ||
- --error-on-warnings | ||
- repo: https://github.com/shellcheck-py/shellcheck-py | ||
rev: v0.10.0.1 | ||
hooks: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,21 @@ | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New config is a result of the following v2 release: https://biomejs.dev/guides/upgrade-to-biome-v2/ |
||
"files": { | ||
"ignore": [".mypy_cache/", ".pixi/"] | ||
}, | ||
"root": false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess it's needed because pre-commit creates another one root config on the fly.
|
||
"extends": "//", | ||
"formatter": { | ||
"enabled": true, | ||
"useEditorconfig": true | ||
"useEditorconfig": true, | ||
"lineWidth": 120 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
}, | ||
"organizeImports": { | ||
"enabled": true | ||
"assist": { | ||
"enabled": true, | ||
"actions": { | ||
"recommended": true | ||
} | ||
}, | ||
"linter": { | ||
"enabled": true, | ||
"rules": { | ||
"all": true | ||
"recommended": true | ||
} | ||
}, | ||
"javascript": { | ||
"globals": ["$"] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From here
https://github.com/github/gitignore/blob/fc6ce5da28a8c3480cc8a5acad050449f72a9261/Python.gitignore#L170-L173