Filter all Helm prerelease versions (beta, alpha, rc) in HelmInstallerV1 #21437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent installing unreleased final version Related: - helm/helm#31472 We will probably have to limit to v3 soon. Signed-off-by: Benoit Tigeot <[email protected]>
benoittgt
changed the title
Author
|
@microsoft-github-policy-service agree company="Lifen" |
Prevent installing unreleased final version Related: - helm/helm#31472 We will probably have to limit to v3 soon. Signed-off-by: Benoit Tigeot <[email protected]>
benoittgt
force-pushed
the
prevent-installing-prerelease-helm
branch
from
d41938f to
d973b0b
Compare
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 21437 in repo microsoft/azure-pipelines-tasks |
3 tasks
Author
|
No more needed #21435 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Describe the context or motivation for this PR. Include links to any related Azure DevOps Work Items or GitHub issues.
📌 How to link to ADO Work Items
Prevent installing unreleased final version as it brokes the task.
Related:
Closes #21436
We will probably have to limit to v3 soon, v4 will be released during KubeCon 2025.
Task Name
Name of the updated or newly created pipeline task.
HelmInstaller@v1
Description
Summarize the changes made in this PR clearly and concisely.
Prevent installing rc/beta/alpha versions of Helm.
Risk Assessment (Low / Medium / High)
Assess the level of risk and provide reasoning (e.g., scope, impact, backward compatibility).
Low
Change Behind Feature Flag (Yes / No)
Can this change be behine feature flag, if not why?
No, this is fixing a bug that impact all users that do not specify a
helmVersionToInstall.Tech Design / Approach
Changed version filtering to use GitHub API's
prereleasefield instead of string matching for 'rc'. Thanks topreReleasefield in https://api.github.com/repos/helm/helm/releasesDocumentation Changes Required (Yes/No)
No
Unit Tests Added or Updated (Yes / No)
Yes - Added 3 test cases to verify prerelease filtering logic.
Additional Testing Performed
None - basic unit tests cover the filtering logic changes.
Logging Added/Updated (Yes/No)
No
Telemetry Added/Updated (Yes/No)
No
Rollback Scenario and Process (Yes/No)
No
Dependency Impact Assessed and Regression Tested (Yes/No)
Yes - Changes are isolated to version selection logic. Existing functionality unchanged.
Checklist