Skip to content

Filter all Helm prerelease versions (beta, alpha, rc) in HelmInstallerV1 #21437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Filter all Helm prerelease versions (beta, alpha, rc) in HelmInstallerV1 #21437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e760feb
Filter all Helm prerelease versions (beta, alpha, rc) in HelmInstaller
benoittgt Nov 10, 2025
d973b0b
Filter all Helm prerelease versions (beta, alpha, rc) in HelmInstaller
benoittgt Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Tasks/HelmInstallerV0/src/helminstaller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ async function getStableHelmVersion(): Promise<string> {
const responseArray = JSON.parse(fs.readFileSync(downloadPath, 'utf8').toString().trim());
let latestHelmVersion = semver.clean(stableHelmVersion);
responseArray.forEach(response => {
if (response && response.tag_name) {
if (response && response.tag_name && !response.prerelease) {
let currentHelmVerison = semver.clean(response.tag_name.toString());
if (currentHelmVerison) {
if (currentHelmVerison.toString().indexOf('rc') == -1 && semver.gt(currentHelmVerison, latestHelmVersion)) {
if (semver.gt(currentHelmVerison, latestHelmVersion)) {
//If current helm version is not a pre release and is greater than latest helm version
latestHelmVersion = currentHelmVerison;
}
Expand Down
15 changes: 15 additions & 0 deletions Tasks/HelmInstallerV1/Tests/L0.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,19 @@ describe('HelmInstallerV1 Suite', function () {
// TODO - add real tests
done();
});

it('Should filter out prerelease versions using prerelease field', function() {
const mockResponse = [
{ tag_name: "v4.0.0-rc.1", prerelease: true },
{ tag_name: "v4.0.0-beta.1", prerelease: true },
{ tag_name: "v4.0.0-alpha.1", prerelease: true },
{ tag_name: "v3.15.4", prerelease: false },
{ tag_name: "v3.15.3", prerelease: false }
];

const stableVersions = mockResponse.filter(r => !r.prerelease);
assert.strictEqual(stableVersions.length, 2, 'Should filter out all prerelease versions');
assert.strictEqual(stableVersions[0].tag_name, 'v3.15.4');
assert.strictEqual(stableVersions[1].tag_name, 'v3.15.3');
});
});
2 changes: 1 addition & 1 deletion Tasks/HelmInstallerV1/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"version": {
"Major": 1,
"Minor": 263,
"Patch": 0
"Patch": 1
},
"preview": true,
"demands": [],
Expand Down