-
Notifications
You must be signed in to change notification settings - Fork 21
Fix label/ID detection — support JSX expression literals, identifier refs and multi-id aria values #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix label/ID detection — support JSX expression literals, identifier refs and multi-id aria values #153
Conversation
@microsoft-github-policy-service agree company="Microsoft" |
https://github.com/microsoft/eslint-plugin-fluentui-jsx-a11y into users/sidhshar/fix-label-detection-jsx-expression-ids
aubreyquinn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's expand the tests to make sure we have every scenario covered.
…is needed for the id=case.
… better readability.
Needful is done. Thanks! |
Corrects id/identifier handling and improves aria-labelledby/aria-describedby detection so rules correctly recognize labels referenced via:
Key details: