fix(trace-viewer): use Uint8ArrayWriter to fix large trace loading#39894
Open
cyphercodes wants to merge 2 commits intomicrosoft:mainfrom
Open
fix(trace-viewer): use Uint8ArrayWriter to fix large trace loading#39894cyphercodes wants to merge 2 commits intomicrosoft:mainfrom
cyphercodes wants to merge 2 commits intomicrosoft:mainfrom
Conversation
…race viewer When network requests are canceled (status -1), the trace viewer was showing a blank status cell. This change displays 'Canceled' instead for better visibility. Fixes microsoft#39887
… Service Workers Replace TextWriter and BlobWriter with Uint8ArrayWriter in ZipTraceLoaderBackend to fix 'TypeError: Failed to fetch' errors when opening large traces (>10MB). The zip.js TextWriter and BlobWriter classes internally use `new Response(readableStream).blob()` which fails in Chromium's Service Worker environment for large data (~10MB+). Uint8ArrayWriter accumulates chunks directly in memory, bypassing this issue. Fixes microsoft#39845
|
@cyphercodes please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
TextWriterandBlobWriterwithUint8ArrayWriterinZipTraceLoaderBackendto fix 'TypeError: Failed to fetch' errors when opening large traces (>10MB).Problem
The zip.js
TextWriterandBlobWriterclasses internally usenew Response(readableStream).blob()which fails in Chromium's Service Worker environment for large data (~10MB+). This causes the trace viewer to fail with:TypeError: Failed to fetchTypeError: Cannot close a ERRORED writable streamTypeError: Cannot set properties of undefined (setting 'outputSize')Solution
Use
Uint8ArrayWriterwhich accumulates chunks directly in memory, completely bypassing thenew Response(readableStream).blob()path that fails in Service Workers.Changes
readText(): UseUint8ArrayWriter+TextDecoderinstead ofTextWriterreadBlob(): UseUint8ArrayWriter+Blobconstructor instead ofBlobWriterFixes #39845