Skip to content

fix(trace-viewer): use Uint8ArrayWriter to fix large trace loading #39894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyphercodes wants to merge 2 commits into from
+6 −5
Closed

fix(trace-viewer): use Uint8ArrayWriter to fix large trace loading #39894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6680c4
fix(trace-viewer): show 'Canceled' for canceled network requests in t…
cyphercodes Mar 27, 2026
3d03393
fix(trace-viewer): use Uint8ArrayWriter to fix large trace loading in…
cyphercodes Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/trace-viewer/src/sw/traceLoaderBackends.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,19 +66,19 @@ export class ZipTraceLoaderBackend implements TraceLoaderBackend {
const entry = entries.get(entryName);
if (!entry)
return;
const writer = new zipjs.TextWriter();
const writer = new zipjs.Uint8ArrayWriter();
await entry.getData?.(writer);
return writer.getData();
return new TextDecoder().decode(writer.getData());
}

async readBlob(entryName: string): Promise<Blob | undefined> {
const entries = await this._entriesPromise;
const entry = entries.get(entryName);
if (!entry)
return;
const writer = new zipjs.BlobWriter() as zip.BlobWriter;
const writer = new zipjs.Uint8ArrayWriter();
await entry.getData!(writer);
return writer.getData();
return new Blob([writer.getData()]);
}
}

Expand Down
3 changes: 2 additions & 1 deletion packages/trace-viewer/src/ui/networkTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,9 @@ const renderCell = (entry: RenderedEntry, column: ColumnName): RenderedGridCell
if (column === 'method')
return { body: entry.method };
if (column === 'status') {
const statusBody = entry.status.code > 0 ? entry.status.code : (entry.status.code === -1 ? 'Canceled' : '');
return {
body: entry.status.code > 0 ? entry.status.code : '',
body: statusBody,
title: entry.status.text
};
}
Expand Down