Skip to content

Conversation

@iamAbhi-916
Copy link
Contributor

@iamAbhi-916 iamAbhi-916 commented Dec 2, 2025

Description

Fix crash when image loading fails due to network error for instance shut down metro while app is running

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

Maintains app lifecycle and gracefully handle network issues while loading image for example RN logbox.

Resolves [Add Relevant Issue Here]
#15427

What

Added lessthrow_await_adapter for HTTP requests instead of direct co_await
and Check asyncOp.Status on error/cancel
Added null check for m_responseHeaders before iteration.

Screenshots

app_network_imagemanager_fix.mp4

Testing

tested in playground and sample app fabric

Changelog

Should this change be included in the release notes: _indicate yes

Add a brief summary of the change to use in the release notes for the next release.
Fixed app crash when loading images with no network connection

Microsoft Reviewers: Open in CodeFlow

@iamAbhi-916 iamAbhi-916 self-assigned this Dec 2, 2025
@iamAbhi-916 iamAbhi-916 added the Area: Fabric Support Facebook Fabric label Dec 2, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Dec 2, 2025
@iamAbhi-916 iamAbhi-916 marked this pull request as ready for review December 2, 2025 10:23
@iamAbhi-916 iamAbhi-916 requested a review from a team as a code owner December 2, 2025 10:23
@iamAbhi-916 iamAbhi-916 changed the title [Fix crash] when image loading fails due to network error for instance shut down metro while app is running [Fix crash] Image loading fails due to network error for instance shut down metro while app is running Dec 2, 2025
@iamAbhi-916 iamAbhi-916 merged commit 92d8c80 into microsoft:main Dec 4, 2025
30 checks passed
@iamAbhi-916 iamAbhi-916 deleted the imagemanager-network-fix branch December 4, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Fabric Support Facebook Fabric New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants