Skip to content

[Fix crash] Image loading fails due to network error for instance shut down metro while app is running #15428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamAbhi-916 merged 7 commits into from
Dec 4, 2025
+423 −348
Merged

[Fix crash] Image loading fails due to network error for instance shut down metro while app is running #15428

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
39510c0
Fix crash when image loading fails due to network error
iamAbhi-916 Dec 2, 2025
a24b368
Change files
iamAbhi-916 Dec 2, 2025
174157a
add generic error message for network request failure
iamAbhi-916 Dec 3, 2025
4a97a12
Merge branch 'main' into imagemanager-network-fix
iamAbhi-916 Dec 3, 2025
1b9a575
update yarn lock
iamAbhi-916 Dec 3, 2025
dfcd08b
update lockfile
iamAbhi-916 Dec 4, 2025
32d49f2
update missing packages and upgrade react native platform override to…
iamAbhi-916 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-a9b5580b-f55c-4089-b03b-1778429afec7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Fix crash when image loading fails due to network error",
"packageName": "react-native-windows",
"email": "[email protected]",
"dependentChangeType": "patch"
}
8 changes: 5 additions & 3 deletions vnext/Microsoft.ReactNative/Fabric/Composition/UriImageManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,11 @@ ImageResponseOrImageErrorInfo ImageFailedResponse::ResolveImage() {
if (imageOrError.errorInfo->error.empty()) {
imageOrError.errorInfo->error = "Failed to load image.";
}
for (auto &&[header, value] : m_responseHeaders) {
imageOrError.errorInfo->httpResponseHeaders.push_back(
std::make_pair<std::string, std::string>(winrt::to_string(header), winrt::to_string(value)));
if (m_responseHeaders) {
for (auto &&[header, value] : m_responseHeaders) {
imageOrError.errorInfo->httpResponseHeaders.push_back(
std::make_pair<std::string, std::string>(winrt::to_string(header), winrt::to_string(value)));
}
}
return imageOrError;
}
Expand Down
14 changes: 13 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/WindowsImageManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include <Fabric/Composition/ImageResponseImage.h>
#include <Fabric/Composition/UriImageManager.h>
#include <Networking/NetworkPropertyIds.h>
#include <Utils/CppWinrtLessExceptions.h>
#include <Utils/ImageUtils.h>
#include <fmt/format.h>
#include <functional/functor.h>
Expand Down Expand Up @@ -131,7 +132,18 @@ WindowsImageManager::GetImageRandomAccessStreamAsync(
request.Content(bodyContent);
}

winrt::Windows::Web::Http::HttpResponseMessage response(co_await m_httpClient.SendRequestAsync(request));
auto asyncOp = m_httpClient.SendRequestAsync(request);
co_await lessthrow_await_adapter<winrt::Windows::Foundation::IAsyncOperationWithProgress<
winrt::Windows::Web::Http::HttpResponseMessage,
winrt::Windows::Web::Http::HttpProgress>>{asyncOp};

if (asyncOp.Status() == winrt::Windows::Foundation::AsyncStatus::Error ||
asyncOp.Status() == winrt::Windows::Foundation::AsyncStatus::Canceled) {
co_return winrt::Microsoft::ReactNative::Composition::ImageFailedResponse(
L"Network request failed: A connection with the server could not be established.");
}

winrt::Windows::Web::Http::HttpResponseMessage response = asyncOp.GetResults();

if (!response.IsSuccessStatusCode()) {
co_return winrt::Microsoft::ReactNative::Composition::ImageFailedResponse(
Expand Down
Loading