Skip to content

Conversation

laurenastrid1
Copy link
Contributor

Pull Request Template – vscode-mssql

Description

Fixes #20199

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copy link

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 55.58% 55.57% ⚪ 0.00%
VSIX Size 4852 KB 4852 KB ⚪ 0 KB ( 0% )
Webview Bundle Size 4008 KB 4008 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.69%. Comparing base (2c77db9) to head (f902cb8).

Files with missing lines Patch % Lines
src/deployment/fabricProvisioningHelpers.ts 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20299      +/-   ##
==========================================
- Coverage   53.70%   53.69%   -0.01%     
==========================================
  Files         198      198              
  Lines       17267    17267              
  Branches     1156     1156              
==========================================
- Hits         9273     9272       -1     
- Misses       7994     7995       +1     
Files with missing lines Coverage Δ
src/deployment/deploymentWebviewController.ts 9.80% <ø> (+0.09%) ⬆️
src/deployment/fabricProvisioningHelpers.ts 43.79% <0.00%> (-0.48%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laurenastrid1 laurenastrid1 merged commit d14ec84 into main Oct 14, 2025
3 checks passed
@laurenastrid1 laurenastrid1 deleted the laurenastrid1/fabricProvisioningWorkspaceChangeBug branch October 14, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Fabric SQL provision - tenant dropdown is changing when you select one you don't have permission for, and you type in the database

5 participants