Skip to content

Fixes workspace form item bug in Fabric Provisioning #20299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2025
Merged

Fixes workspace form item bug in Fabric Provisioning #20299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cfc4d7
fixes workspace changing bug
Oct 13, 2025
387995c
remove log statments
Oct 13, 2025
f902cb8
fully remove uneccessary log statements
Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/deployment/deploymentWebviewController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ export class DeploymentWebviewController extends FormWebviewController<
});

this.registerReducer("createConnectionGroup", async (state, payload) => {
console.log("Creating connection group with spec:", payload.connectionGroupSpec);
const createConnectionGroupResult: IConnectionGroup | string =
await createConnectionGroup(
payload.connectionGroupSpec,
Expand Down
7 changes: 5 additions & 2 deletions src/deployment/fabricProvisioningHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,6 @@ export async function getWorkspaces(
},
);
} catch (err) {
console.log(err);
state.isWorkspacesErrored = true;
sendErrorEvent(
TelemetryViews.FabricProvisioning,
Expand Down Expand Up @@ -623,6 +622,9 @@ export async function handleWorkspaceFormAction(
state: fp.FabricProvisioningState,
workspaceId: string,
): Promise<fp.FabricProvisioningState> {
// Clean up "databaseName" error if new workspace is selected
state.formErrors = state.formErrors.filter((err) => err !== "databaseName");

const workspace = state.workspacesWithPermissions[workspaceId];

// Check if the workspace has a role
Expand All @@ -648,13 +650,14 @@ export async function handleWorkspaceFormAction(
}

// Validate the workspace
state.formState.workspace = workspace.id;
state.formState.workspace = workspaceId;
const workspaceComponent = state.formComponents["workspace"];
const workspaceValidation = workspaceComponent.validate(state, state.formState.workspace);
workspaceComponent.validation = workspaceValidation;
if (!workspaceValidation.isValid) {
state.formErrors.push("workspace");
state.databaseNamesInWorkspace = [];
return state;
} else {
const startTime = Date.now();

Expand Down