Skip to content

Conversation

@moselhy
Copy link

@moselhy moselhy commented Mar 26, 2021

For #10632

jedi.api.names has been deprecated, use new syntax instead.

  • note I could have used the Script object initialized in the lines right below the change, but I went the safe route since the method enclosing the change returns pre-emptively

jedi.api.names has been deprecated, use new syntax instead.
* note I could have used the Script object initialized in the lines right below the change, but I went the safe route since the method enclosing the change returns pre-emptively
@ghost
Copy link

ghost commented Mar 26, 2021

CLA assistant check
All CLA requirements met.

@karthiknadig karthiknadig requested a review from karrtikr March 29, 2021 20:58
Co-authored-by: Karthik Nadig <[email protected]>
@karthiknadig karthiknadig merged commit 7802743 into microsoft:main Apr 1, 2021
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0%. Comparing base (b8c66c4) to head (d446230).
⚠️ Report is 2347 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##           main   #15791    +/-   ##
======================================
- Coverage    46%       0%   -47%     
======================================
  Files        12        7     -5     
  Lines       429       14   -415     
  Branches     60        1    -59     
======================================
- Hits        201        0   -201     
+ Misses      216       14   -202     
+ Partials     12        0    -12     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants